[ASCollectionView] When Resizing, Invalidate Layout After Remeasuring #1931
Conversation
ghost
added
the
| @@ -857,7 +857,7 @@ - (void)layoutSubviews | |||
| _nextLayoutInvalidationStyle = ASCollectionViewInvalidationStyleNone; | |||
| switch (invalidationStyle) { | |||
| case ASCollectionViewInvalidationStyleWithAnimation: | |||
| if (!_superPerformingBatchUpdates) { | |||
| if (0 == _superBatchUpdateCount) { | |||
There was a problem hiding this comment.
@appleguy @Adlai-Holler What is the opinion about the code style? I personally would prefer _superBatchUpdateCount == 0, but we should find a way that works for all and the future
There was a problem hiding this comment.
For BOOLs I prefer NO == _myBool so you can immediately see the NO. For all other assignments this "defensive ordering" with constant on the left prevents people from accidentally using a single =, so I think we should standardize on that.
There was a problem hiding this comment.
FWIW, I'm pretty sure the compiler catches a single = for you now.
There was a problem hiding this comment.
@Adlai-Holler I understand the value in this style, but for now let's match the prevailing style, which is == NO
|
One comment but otherwise looks good |
|
Assuming this passes user testing, it sounds like this should be cherry picked to 6.8 |
This fixes rotation issues @rcancro and I have seen. It is still being tested.