This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[ASTextNode] use accessor for pointSizeScaleFactors
#1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a subclass of `ASTextNode` that uses `pointSizeScaleFactors`. Currently I have to recompute the scale factors any time the font size changes. If `_rendererAttributes` used the property accesor for the scale factors I would only have to create them when asked. I hope this little change can make it in :)
ghost
added
the
|
@rcancro LGTM. Can you add a comment why we use the property access explicitly in this case. Thanks! |
|
👍 Game changer. |
Adlai-Holler
pushed a commit
that referenced
this pull request
Jul 15, 2016
[ASTextNode] use accessor for `pointSizeScaleFactors`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a subclass of
ASTextNodethat usespointSizeScaleFactors. Currently I have to recompute the scale factors any time the font size changes. If_rendererAttributesused the property accesor for the scale factors I would only have to create them when asked. I hope this little change can make it in :)