This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[ASDisplayNode] Allow measure always be off the main thread #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
If applyLayout:layoutTransition is called on a background thread, is it possible that a subnode involved in the transition could get its node loaded on the main thread after |
Currently measurement always needs to happen on the main thread if implicit hierarchy management is enabled as adding and removing from nodes needs to happen on the main thread. We now will trampoline to the main thread to do the insertion and deletion of nodes. This also resolves the issue that can occur if a node is already loaded deep in the layout hierarchy in the layout that the node is transforming to. Before insertion or deletion is happening we need to crawl the layout hierarchy to check that though.
| @@ -838,8 +846,8 @@ - (void)setUsesImplicitHierarchyManagement:(BOOL)value | |||
|
|
|||
| - (BOOL)_hasTransitionInProgress | |||
There was a problem hiding this comment.
This should be _isTransitionInProgress
|
@Adlai-Holler Theoretically this can happen, in fact this can already happen with the current implementation too. So in this nothing will change. I don't know at the moment a good way to fix that, but we definitely should consider it in the broader refactoring around layout transitions that I'm working on. @levi Addressed your comments @levi @appleguy @Adlai-Holler Can I get another look on it. Thanks! |
|
Awesome! Time to 🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently measurement always needs to happen on the main thread if implicit hierarchy management is enabled as adding and removing from nodes needs to happen on the main thread. We now will trampoline to the main thread to do the insertion and deletion of nodes.
This also resolves the issue that can occur if a node is already loaded deep in the layout hierarchy in the layout that the node is transforming to. Before insertion or deletion is happening we need to crawl the layout hierarchy to check that though.
Open things:
shouldMeasureAsyncparameter intransitionLayoutWithAnimation:shouldMeasureAsync:measurementCompletion:that I think should not be exposed at all - @levi any thoughts on that?_applyLayout:layoutTransition:to abort the insertion or deletion of nodes if the block runs on the main thread?@appleguy @Adlai-Holler @levi Would be great if I could get a review and thoughts