This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[ASVideoNode] Ensure that both ASVideoNode and ASNetworkImageNode delegate methods are called #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egate methods are called for ASVideoNode observers
ghost
added
the
|
@gazreese: Thanks for catching this - sorry I missed this! |
|
@Adlai-Holler @maicki: this PR LGTM. It's an easy one-liner (excluding testing code). |
|
Let's take this to the hoop! 👍 |
|
Thanks guys! |
| @@ -453,7 +453,9 @@ - (AVPlayer *)player | |||
|
|
|||
| - (void)setDelegate:(id<ASVideoNodeDelegate>)delegate | |||
| { | |||
| [super setDelegate:delegate]; | |||
There was a problem hiding this comment.
@gazreese ak, thanks for fixing this!!!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the user of ASVideoNode could set the .delegate property but the ASNetworkImageNode delegate methods were not called. This meant that the client of ASVideoNode was not able to observe image progress or errors.
I've tested this both with the test harness and in my own project.