This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Use correct format identifiers for logs on 64 bit systems. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secretiverhyme
added a commit
that referenced
this pull request
Jun 27, 2014
Use correct format identifiers for logs on 64 bit systems.
|
Thanks! |
|
nice. |
appleguy
pushed a commit
that referenced
this pull request
Apr 1, 2016
[Documentation] update README.md
4 tasks
garrettmoon
added a commit
to garrettmoon/AsyncDisplayKit
that referenced
this pull request
Apr 11, 2017
* Adding buildkite support * Update build.sh to support all flag
nguyenhuy
pushed a commit
to nguyenhuy/AsyncDisplayKit
that referenced
this pull request
Apr 18, 2017
* Adding buildkite support * Update build.sh to support all flag
aimalygin
pushed a commit
to aimalygin/AsyncDisplayKit
that referenced
this pull request
Apr 18, 2017
* Adding buildkite support * Update build.sh to support all flag
peter-iakovlev
pushed a commit
to peter-iakovlev/AsyncDisplayKit
that referenced
this pull request
Oct 10, 2018
…ve#1154) This is a follow up on facebookarchive#1136. Our experiment results show that clearing data frequently is the cause of our facebookarchive#1 crash. @maicki and I believe that this is because if the collection view is being used, silently clearing its data without notifying the backing UICollectionView can put it out-of-sync and causes mayhem next time the collection view processes a batch update. If you look at the stack trace closely, you'll notice that the crash doesn't occur on the same run loop that clearData is called. This made it extremely tricky to investigate and identify the root cause. Another interesting question would be whether or not we want to clear the data during deallocation at all, since the data will be cleared out soon anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect format identifiers were being used for NS(U)Integer, and as such were generating warnings on 64 Bit Builds. Based on: https://twitter.com/gparker/status/377910611453046784
I've also silenced the insertSublayer:atIndex: implicit conversion warning.