Table View Thrash Tests Should Be Enabled

[Adlai-Holler]

Currently ASTableViewThrashTests.testThrashingWildly is disabled because, when run alongside other tests, we see Node should always be marked invisible before deallocating issues.

In #2435, we can go the easy route if we solve this issue and re-enable ASTableViewThrashTests.testThrashingWildly. The hard route is pretty brutal.

[Adlai-Holler]

The first step is to use the exception breakpoint to find out where that exception is thrown when running all unit tests with Cmd+U. It is thrown from other test methods, which implies that the table view or window from the thrash testing is not cleaned up properly.

One initial approach is to look at how the window used in the thrash tests is torn down, and try explicitly removing the table view from the window before letting the window deallocate.

[Adlai-Holler]

After a good bit of work on this yesterday, I have gotten the test method to always fail inside the test case if it's going to fail. Unfortunately the thrash tests still contain surplus cases of "Node must be marked invisible before deallocation" and so I probably can't reenable them today. Later today I'll open a diff that modifies the test method to make sure it fails inside the test case.

Removing from the milestone since the code isn't public-facing and the underlying issues I've exposed probably won't be fixed today.

[Adlai-Holler]

Resolved in linked PRs