Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

[ASMapNode] Setting region on ASMapNode doesn't work when liveMap = false #1754

Closed
george-gw opened this issue Jun 16, 2016 · 1 comment
Closed

Comments

@george-gw
Copy link
Contributor

george-gw commented Jun 16, 2016

Scenario:
1- Create ASMapNode
2- Set region with mapNode.region = /* new region */

Expected result: snapshot shows the map at region
Actual result: snapshot shows the world map

Workaround:
1- Create new: MKMapSnapshotOptions, let's call it newOptions
2- Set same options as mapNode.options to it // for consistency's sake
3- Change newOptions.region = /* new region */
4- Set new options: mapNode.options = newOptions

@hannahmbanana
Copy link
Contributor

@george-gw: this also looks like it is a bug. I'll go ahead and submit a PR to fix it.

george-gw added a commit to george-gw/AsyncDisplayKit that referenced this issue Jun 17, 2016
…ive#1753)

ASMapNode: Change map snapshot when updating it with a new region (facebookarchive#1754)
ASMapNode: Commented out code that is causing inaccurate behavior
george-gw added a commit to george-gw/AsyncDisplayKit that referenced this issue Jun 17, 2016
…ive#1753)

ASMapNode: Change map snapshot when updating it with a new region (facebookarchive#1754)
ASMapNode: Commented out code that is causing inaccurate behavior
Added a basic example for ASMapNode to try out the different changes
george-gw added a commit to george-gw/AsyncDisplayKit that referenced this issue Jun 21, 2016
…hive#1753)

[ASMapNode] Change map snapshot when updating it with a new region (facebookarchive#1754)
[ASMapNode] Commented out code that is causing inaccurate behavior
[ASMapNode] Added the ability to zoom in and show annotations, similar to showAnnotations:animated: of MKMapView.
Added a basic example for ASMapNode to try out the different changes
aimalygin pushed a commit to aimalygin/AsyncDisplayKit that referenced this issue Sep 16, 2020
* master_up: (29 commits)
  [ASDisplayNode] Resolve background color using system trait collection (facebookarchive#1777)
  Prevent crashing during non critical logging at rotation (facebookarchive#1770)
  Fix calling CALayer out of the main thread (facebookarchive#1762)
  Pruning ASExperimentalRemoveTextKitInitialisingLock code.  (facebookarchive#1766)
  Fix typo in examples/README.md (facebookarchive#1759)
  Lint podspec on all pull requests (facebookarchive#1758)
  Link to IGListDiffKit in our IGListKit subspec (facebookarchive#1756)
  Omit UIUserInterfaceLevel from tvOS build (facebookarchive#1757)
  Add empty ASViewController initializer to facilitate subclassing (facebookarchive#1754)
  Remove references to xcpretty-travis-formatter (facebookarchive#1755)
  Simplify push_back `GroupNotify` (facebookarchive#1736)
  First pass at supporting new traits (facebookarchive#1568)
  Use `queue` in `ASMainSerialQueue` (facebookarchive#1738)
  Bump up IGListKit version (facebookarchive#1749)
  [ASCollectionLayout] Fix element lookup for supplementary attributes (facebookarchive#1707)
  Delete unused macro in `ASControlNode` (facebookarchive#1734)
  Improve recursive unfair lock: (facebookarchive#1742)
  [Docs] minor fixes in `Layout` (facebookarchive#1735)
  Delete unused header in `ASRunLoopQueue` (facebookarchive#1737)
  Fix tint color dead lock facebookarchive#1731 (facebookarchive#1732)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants