make it more clear why eden chown tests are disabled on macOS

MichaelCuevas · facebook-github-bot · commit 4961b1001179 · 2023-03-09T10:22:02.000-08:00
Summary: There are 2 reasons why this test is disabled: 1) `eden chown` crashes on macOS 2) Even if `eden chown` worked on macOS, it would require passwordless `sudo` which is not available on macOS Sandcastle hosts where we run our contbuild and diff time tests. Since #2 is a big issue that we can't work around, let's disable the test. Due to the test war room, I won't be fixing #1 in this diff. However, I created T147554174 to track fixing it. Reviewed By: fanzeyi Differential Revision: D43926151 fbshipit-source-id: f1572d2b876d45affdcdebf9b567e23c7730076a
diff --git a/eden/integration/lib/skip.py b/eden/integration/lib/skip.py
@@ -204,7 +204,9 @@
         "test_statvfs",
     ]
 
-    # `edenfsctl chown` requires sudo
+    # `eden chown` requires the use of `sudo` for chowning redirections. We
+    # don't have access to passwordless `sudo` on macOS Sandcastle hosts, so
+    # we should disable these test.
     TEST_DISABLED["chown_test.ChownTest"] = True
 
     # I'm not sure if overlay corruption logic even exists on macOS?

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,9 @@`
`204`	`204`	`"test_statvfs",`
`205`	`205`	`]`
`206`	`206`
`207`		- # `edenfsctl chown` requires sudo
	`207`	+ # `eden chown` requires the use of `sudo` for chowning redirections. We
	`208`	+ # don't have access to passwordless `sudo` on macOS Sandcastle hosts, so
	`209`	`+ # we should disable these test.`
`208`	`210`	`TEST_DISABLED["chown_test.ChownTest"] = True`
`209`	`211`
`210`	`212`	`# I'm not sure if overlay corruption logic even exists on macOS?`