Allow writes during SST file ingestion #14142
Open
+84
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #14137.
Summary: This change adds an
allow_writeoption to IngestExternalFileOptions to allow writes to the DB during file ingestion. Previously, ingestion always blocked writes by entering write threads. With this option enabled, write operations can proceed concurrently with ingestion.The main changes are in DBImpl::IngestExternalFile to conditionally skip blocking write threads based on the
allow_writeflag:Additionally:
Users must ensure no writes overlap with the ingested data when using this option. This is useful for maintaining write availability during bulk data ingestion operations in scenarios where the ingested data does not conflict with ongoing writes.
Test Plan: Updated all existing test cases in external_sst_file_test.cc to support the new parameter with default value (false). All 202 tests pass successfully.