Update throw-on-field-error-directive.md #5039
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently on https://relay.dev/docs/guides/throw-on-field-error-directive/, this slash at the end of the file name will result in a double slash when visiting the site. This change will remove the double slash and make the link work.
|
Interesting! I've seen other issues with broken links related to trailing slashes. Do you want to grep for all such Could you also confirm that the link still works by doing a full build of the docs and clicking the link (if you haven't already). Thanks again for looking into this! |
|
Ping @christiansany |
This was referenced Aug 1, 2025
Closed
|
I've opened #5049 in an attempt to fix this issue and others in historical versions of the docs. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
Summary: Expanding upon #5039 to catch all such instances. Search for regex `\.mdx?/`. Pull Request resolved: #5049 Test Plan: Ran the docs in dev mode and confirmed that I could click the link and get to the why-null page at the right anchor Reviewed By: evanyeung Differential Revision: D79477408 Pulled By: captbaritone fbshipit-source-id: 1d2ce71714ba7d7309029081288cbb8e342f510d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on https://relay.dev/docs/guides/throw-on-field-error-directive/, this slash at the end of the file name will result in a double slash when trying to visit the site it links to (-> link is broken).
This change will remove the double slash and make the link work.