Relay 13: @no_inline directive doesn't work correctly for fragments in a different directory (non-Haste mode)

[mrtnzlml]

Hola 👋 , I discovered an issue with @no_inline directive. Basically, it works well when you use it on a simple fragment (it generates the *$normalization.graphql.js file and corresponding requires as expected). However, when the fragment is used somewhere further away (say in __tests__ or in some other distant location) it still generates the normalization file nearby the fragment but the requires are pointing to a non-existing file.

For example:

src/example-relay/src/Homepage/locations
├── Location.js
├── __generated__
│   ├── Location$normalization.graphql.js
│   ├── Location.graphql.js
│   └── ...
└── __tests__
    ├── LocationsPaginatedRefetch.test.js
    └── __generated__
        └── LocationsPaginatedRefetchTestQuery.graphql.js

The requires are correct under __generated__ but they are wrong under __tests__/__generated__ because the require looks like this:

{
  "args": null,
  "fragment": require('./Location$normalization.graphql'), // doesn't exist under `__tests__/__generated__`
  "kind": "FragmentSpread"
},

I hope it's understandable what I am trying to describe. 😬

[alunyov]

I think this may only work now when using a single artifactsDirectory for all generated artifacts. Can you try this?

Internally, everything is working because we're using Haste requires (using just module name without a path).

[mrtnzlml]

I can imagine how this would work with Haste or artifacts directory without any issues, yes. So this issue might be more like a feature request: to support @no_inline with the default Relay OSS configuration (CommonJS, no artifacts directory).

Personally, I do not want to use the artifacts directory but I can imagine having one directory for these normalization files to simplify the whole situation (so the files are not all over the place).