-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modern] ReactRelayPaginationContainer pageInfo warning #1852
Comments
same issue here
I have defined pageInfo fields correctly
|
Is there a fix for this one yet @JenniferWang @programisti ? |
@MaximusDesign Im not sure, I did not played around since that, because I thought was too early to play with Relay Modern. |
Same problem, the warning appears even in case there are simply no edges. |
Same here... |
the check is here
maybe we can improve this condition |
@sibelius I think it should be if (typeof hasMore !== 'boolean' || edges.length > 0 && typeof cursor !== 'string') { as warning happens when zero |
The warning seems correct, according to the spect Some effort to update the spec is happening here #2655 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The ReactRelayPaginationContainer complains about missing pageInfo fields whenever no edges are returned from a connection. Specifically, I am seeing this warning whenever pageInfo.endCursor === null. I am able to silence the warning by returning an empty string for pageInfo.endCursor. Is an empty string the expected value in this situation or am I missing something else?
Example response:
Warning:
The text was updated successfully, but these errors were encountered: