Commit ff27db4
Disable persisted queries in validate mode (#5013)
Summary:
Right now, when the CLI is run in valdiate mode with persisted queries enabled, the compiler fails with connection refused errors (when the persisting server is not available).
This issue is most evident in CI pipelines when generally the persisting server won't be available.
Example error message:
```
➜ accounts (main) relay-compiler --validate ✭
[INFO] Querying files to compile...
[INFO] [default] compiling...
[ERROR] Error: Network error: error trying to connect: tcp connect error: Connection refused (os error 111)
[ERROR] Compilation failed.
[ERROR] Unable to run relay compiler. Error details:
Failed to build:
- Persisting operation(s) failed:
- Network error: error trying to connect: tcp connect error: Connection refused (os error 111)
```
But the expected behaviour is that the query persister must be disabled in validate mode.
This PR attempts to fix that.
Issue(s) closed: #5007
Pull Request resolved: #5013
Reviewed By: tyao1
Differential Revision: D76442518
Pulled By: evanyeung
fbshipit-source-id: 31006555d4f4b1a8fd9679dc67188884388dd0d21 parent 3320532 commit ff27db4
1 file changed
+20
-15
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
328 | 333 | | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
333 | 338 | | |
334 | 339 | | |
335 | 340 | | |
| |||
0 commit comments