required-on-nonnull-field checking to descend into inline fragments

Reviewed By: captbaritone

Differential Revision: D77555111

fbshipit-source-id: e9c871235abe4899b12d9cf09ce158cc4d4d27da

Author: gordyf

compiler/crates/relay-transforms/src/validations/disallow_required_on_non_null_field.rs

@@ -134,11 +134,15 @@ impl<'a> DisallowRequiredOnNonNullField<'a> {
             Selection::ScalarField(scalar_field) => {
                 self.validate_required_field(scalar_field, errors_are_caught)
             }
+            Selection::InlineFragment(fragment) => {
+                self.validate_selection_fields(&fragment.selections, errors_are_caught)
+            }
             _ => Ok(()),
         }))?;
         Ok(())
     }
 }
+
 impl Validator for DisallowRequiredOnNonNullField<'_> {
     const NAME: &'static str = "disallow_required_on_non_null_field";
     const VALIDATE_ARGUMENTS: bool = false;

compiler/crates/relay-transforms/tests/disallow_required_on_non_null_field/fixtures/fragment_with_inline_fragment_required_non_null_fields.invalid.expected

@@ -0,0 +1,19 @@
+==================================== INPUT ====================================
+fragment MyFragment on User @throwOnFieldError {
+  ... on User {
+    some_field @required(action: THROW)
+  }
+}
+
+# %extensions%
+extend type User {
+  some_field: Int!
+}
+==================================== OUTPUT ===================================
+OK; warnings: ℹ Unexpected `@required` directive on a non-null field. This field is already non-null and does not need the `@required` directive.
+
+  fragment_with_inline_fragment_required_non_null_fields.invalid.graphql:3:16
+    2 │   ... on User {
+    3 │     some_field @required(action: THROW)
+      │                ^^^^^^^^^^^^^^^^^^^^^^^^
+    4 │   }

compiler/crates/relay-transforms/tests/disallow_required_on_non_null_field/fixtures/fragment_with_inline_fragment_required_non_null_fields.invalid.graphql

@@ -0,0 +1,10 @@
+fragment MyFragment on User @throwOnFieldError {
+  ... on User {
+    some_field @required(action: THROW)
+  }
+}
+
+# %extensions%
+extend type User {
+  some_field: Int!
+}

compiler/crates/relay-transforms/tests/disallow_required_on_non_null_field_test.rs

@@ -4,14 +4,21 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<12d7bd117492254376fcbcd30baf95f6>>
+ * @generated SignedSource<<b7654cbc0db7924c3b85107ada9f49ba>>
  */
 
 mod disallow_required_on_non_null_field;
 
 use disallow_required_on_non_null_field::transform_fixture;
 use fixture_tests::test_fixture;
 
+#[tokio::test]
+async fn fragment_with_inline_fragment_required_non_null_fields_invalid() {
+    let input = include_str!("disallow_required_on_non_null_field/fixtures/fragment_with_inline_fragment_required_non_null_fields.invalid.graphql");
+    let expected = include_str!("disallow_required_on_non_null_field/fixtures/fragment_with_inline_fragment_required_non_null_fields.invalid.expected");
+    test_fixture(transform_fixture, file!(), "fragment_with_inline_fragment_required_non_null_fields.invalid.graphql", "disallow_required_on_non_null_field/fixtures/fragment_with_inline_fragment_required_non_null_fields.invalid.expected", input, expected).await;
+}
+
 #[tokio::test]
 async fn fragment_with_multiple_required_non_null_fields_invalid() {
     let input = include_str!("disallow_required_on_non_null_field/fixtures/fragment_with_multiple_required_non_null_fields.invalid.graphql");