Update broken url in error message

Summary:
This diff updates the reference url in the error message for the `InvalidConnectionKeyArgPostfix` error.

Also fix some linter errors that were picked up by CI 😅

## More Details

When trying to add a new relay connection, I got an error message in the command line with a url pointing to the relay docs. Specifically, a url to `https://
relay.dev/docs/en/pagination-container#connection`.

{F1980415414}

That url leads to a page that no longer exists...

{F1980415420}

I checked the [history of this page in the wayback machine](https://web.archive.org/web/20210228095734/https://relay.dev/docs/en/pagination-container#connection). In their records, the page used to show this...

{F1980415369}

I think based off of this, the best page to replace the url with is [`https://relay.dev/docs/tutorial/connections-pagination/`](https://relay.dev/docs/tutorial/connections-pagination/).

Update the reference url in the error message for the InvalidConnectionKeyArgPostfix error.

Reviewed By: lynnshaoyu

Differential Revision: D78642574

fbshipit-source-id: eea893744c679fec73a0cea3d7c186a21883d0f6

Author: Matthew Saunders

compiler/crates/graphql-ir/src/errors.rs

@@ -354,7 +354,7 @@ pub enum ValidationMessage {
     },
 
     #[error(
-        "Expected the {key_arg_name} argument to @{connection_directive_name} to be of form '<SomeName>_{postfix}', got '{key_arg_value}'. For a detailed explanation, check out https://relay.dev/docs/en/pagination-container#connection"
+        "Expected the {key_arg_name} argument to @{connection_directive_name} to be of form '<SomeName>_{postfix}', got '{key_arg_value}'. For a detailed explanation, check out https://relay.dev/docs/tutorial/connections-pagination/"
     )]
     InvalidConnectionKeyArgPostfix {
         connection_directive_name: DirectiveName,
@@ -465,7 +465,7 @@ pub enum ValidationMessage {
 
     #[error("The field `{parent_name}.{field_name}` is deprecated.{}",
         match deprecation_reason {
-            Some(reason) => format!(" Deprecation reason: \"{}\"", reason),
+            Some(reason) => format!(" Deprecation reason: \"{reason}\""),
             None => "".to_string()
         }
     )]
@@ -477,7 +477,7 @@ pub enum ValidationMessage {
 
     #[error("The argument `{argument_name}` of the field `{parent_name}.{field_name}` is deprecated.{}",
     match deprecation_reason {
-        Some(reason) => format!(" Deprecation reason: \"{}\"", reason),
+        Some(reason) => format!(" Deprecation reason: \"{reason}\""),
         None => "".to_string()
     })]
     DeprecatedFieldArgument {
@@ -489,7 +489,7 @@ pub enum ValidationMessage {
 
     #[error("The argument `{argument_name}` of the directive `@{directive_name}` is deprecated.{}",
     match deprecation_reason {
-        Some(reason) => format!(" Deprecation reason: \"{}\"", reason),
+        Some(reason) => format!(" Deprecation reason: \"{reason}\""),
         None => "".to_string()
     })]
     DeprecatedDirectiveArgument {
@@ -640,7 +640,7 @@ impl WithDiagnosticData for ValidationMessageWithData {
                 .map(|suggestion| into_box(*suggestion))
                 .collect::<_>(),
             ValidationMessageWithData::ExpectedSelectionsOnObjectField { field_name, .. } => {
-                vec![Box::new(format!("{} {{ }}", field_name))]
+                vec![Box::new(format!("{field_name} {{ }}"))]
             }
             ValidationMessageWithData::DeprecatedDangerouslyUnaliasedDirective => {
                 vec![Box::new("@alias".to_string())]

compiler/crates/relay-transforms/tests/validate_connections/fixtures/connection-invalid-key-name.invalid.expected

@@ -15,7 +15,7 @@ query NodeQuery($id: ID!) {
   }
 }
 ==================================== ERROR ====================================
-✖︎ Expected the key argument to @connection to be of form '<SomeName>__comments', got 'invalid'. For a detailed explanation, check out https://relay.dev/docs/en/pagination-container#connection
+✖︎ Expected the key argument to @connection to be of form '<SomeName>__comments', got 'invalid'. For a detailed explanation, check out https://relay.dev/docs/tutorial/connections-pagination/
 
   connection-invalid-key-name.invalid.graphql:6:44
     5 │     ... on Story {