Make variables prop in commitMutation param NoInfer to improve errors

Reviewed By: panagosg7

Differential Revision: D77458796

fbshipit-source-id: 0339b5d2769c7aca633c0309ce558c4340d370c6

Author: SamChou19815

packages/relay-runtime/mutations/__tests__/commitMutation-test.js

@@ -145,12 +145,12 @@ describe('Configs: NODE_DELETE', () => {
     store.subscribe(snapshot, callback);
     commitMutation(environment, {
       configs,
-      /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
-       * commitMutation */
       mutation,
       optimisticResponse,
       optimisticUpdater,
       updater,
+      /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
+       * commitMutation */
       variables,
     });
     expect(callback.mock.calls.length).toBe(1);
@@ -598,14 +598,14 @@ describe('Configs: RANGE_ADD', () => {
     store.subscribe(snapshot, callback);
     commitMutation(environment, {
       configs,
-      /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
-       * commitMutation */
-      /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
-       * of commitMutation */
       mutation,
       optimisticResponse,
       optimisticUpdater,
       updater,
+      /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
+       * commitMutation */
+      /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
+       * of commitMutation */
       variables,
     });
     // Optimistically appends
@@ -658,11 +658,11 @@ describe('Configs: RANGE_ADD', () => {
     // send mutation
     commitMutation(environment, {
       configs,
+      mutation,
       /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
        * commitMutation */
       /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
        * of commitMutation */
-      mutation,
       variables,
     });
 
@@ -747,11 +747,11 @@ describe('Configs: RANGE_ADD', () => {
     // send the same mutation again
     commitMutation(environment, {
       configs,
+      mutation,
       /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
        * commitMutation */
       /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
        * of commitMutation */
-      mutation,
       variables,
     });
     environment.mock.resolve(operation, serverResponse);
@@ -831,14 +831,14 @@ describe('Configs: RANGE_ADD', () => {
     store.subscribe(snapshot, callback);
     commitMutation(environment, {
       configs,
-      /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
-       * commitMutation */
-      /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
-       * of commitMutation */
       mutation,
       optimisticResponse,
       optimisticUpdater,
       updater,
+      /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
+       * commitMutation */
+      /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
+       * of commitMutation */
       variables,
     });
     // Optimistically prepends
@@ -900,14 +900,14 @@ describe('Configs: RANGE_ADD', () => {
     store.subscribe(snapshot, callback);
     commitMutation(environment, {
       configs,
-      /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
-       * commitMutation */
-      /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
-       * of commitMutation */
       mutation,
       optimisticResponse,
       optimisticUpdater,
       updater,
+      /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
+       * commitMutation */
+      /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
+       * of commitMutation */
       variables,
     });
     // Optimistically appends orderBy(chronological)
@@ -959,11 +959,11 @@ describe('Configs: RANGE_ADD', () => {
     // send mutation
     commitMutation(environment, {
       updater,
+      mutation,
       /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
        * commitMutation */
       /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
        * of commitMutation */
-      mutation,
       variables,
     });
 
@@ -1054,11 +1054,11 @@ describe('Configs: RANGE_ADD', () => {
     // send the same mutation again
     commitMutation(environment, {
       updater,
+      mutation,
       /* $FlowFixMe[prop-missing] error exposed when improving flow typing of
        * commitMutation */
       /* $FlowFixMe[incompatible-call] error exposed when improving flow typing
        * of commitMutation */
-      mutation,
       variables,
     });
     environment.mock.resolve(operation, serverResponse);

packages/relay-runtime/mutations/commitMutation.js

@@ -71,7 +71,7 @@ export type CommitMutationConfig<TVariables, TData, TRawResponse> = $ReadOnly<{
   optimisticUpdater?: ?SelectorStoreUpdater<TData>,
   updater?: ?SelectorStoreUpdater<TData>,
   uploadables?: UploadableMap,
-  variables: TVariables,
+  variables: NoInfer<TVariables>,
 }>;
 
 /**