Adds CSS Grid properties to list of unitless numbers#9185
Merged
flarnie merged 1 commit intofacebook:masterfrom Apr 20, 2017
Merged
Adds CSS Grid properties to list of unitless numbers#9185flarnie merged 1 commit intofacebook:masterfrom
flarnie merged 1 commit intofacebook:masterfrom
Conversation
Collaborator
|
Is this list exhaustive? |
Contributor
Author
|
It's exhaustive to the CSS grid spec, but not necessarily exhaustive to other newer unitless properties outside of that spec. |
Contributor
|
Initially my questions were:
Clearly though if we already support Thanks for submitting this @ericsakmar! |
flarnie
pushed a commit
that referenced
this pull request
Apr 20, 2017
flarnie
pushed a commit
to flarnie/react
that referenced
this pull request
Jun 7, 2017
1 task
mgol
added a commit
to mgol/react
that referenced
this pull request
Sep 4, 2018
gaearon
pushed a commit
that referenced
this pull request
Sep 4, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
This was referenced Aug 26, 2019
This was referenced Sep 22, 2019
This was referenced Jan 23, 2020
This was referenced Feb 23, 2020
This was referenced Mar 18, 2020
This was referenced Mar 27, 2020
This was referenced May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following CSS Grid properties to the list of unitless numbers:
gridColumnStartgridColumnEndgridColumnSpan(ie/ms only)gridRowStartgridRowEndgridRowSpan(ie/ms only)Without these values in the list, the code appends a
px, which is not valid for these properties.