Remove _resetEventPlugins, use jest.resetModuleRegistry

[aweary]

This isn't called at runtime and is only used in internal unit tests. Despite that, it's currently being included in production builds. This change makes it so only exists DEV removes it and uses jest.resetModuleRegistry in its place.

We might even want to go a step further and define it in our test suite instead since it serves no purpose in DEV either. If that's acceptable, I can update the PR with that approach which seems preferable.

   raw     gz Compared to last run
  +115    +28 build/react-dom-fiber.js
  -243    -50 build/react-dom-fiber.min.js
  +115    +29 build/react-dom-server.js
  -242    -45 build/react-dom-server.min.js
  +115    +29 build/react-dom.js
  -242    -53 build/react-dom.min.js
     =      = build/react-with-addons.js
     =      = build/react-with-addons.min.js
     =      = build/react.js
     =      = build/react.min.js

[gaearon]

I don’t think moving it to unit tests would work since they'd have to depend on internals even more.
Let's keep it gated by DEV.

By the way, why is there a DEV block inside of it?

[aweary]

By the way, why is there a DEV block inside of it?

🤷‍♂️ no clue, that was the existing implementation. I'll remove that too.

[sophiebits]

Can we change the test to use jest.resetModuleRegistry() instead?

[aweary]

@spicyj good call, I've updated the PR to just remove _resetEventsPlugin altogether and use jest.resetModuleRegistry

[gaearon]

Thanks!