Make callbackList a linked-list instead of an array #8752
Conversation
| }; | ||
|
|
||
| function createList<A>() : List<A> { | ||
| return { first: null, last: null }; |
There was a problem hiding this comment.
Meh I guess I should just put these directly on the update queue type :D
There was a problem hiding this comment.
What's more important, that this List type is generic or that we avoid the extra allocation?
There was a problem hiding this comment.
Could also make the List type an intersection of the ListNode type, like the UpdateQueue type was in the first version.
There was a problem hiding this comment.
Making it generic is explicitly a non-goal. If all we need is something super generic. Maybe we can just stick to arrays.
acdlite
force-pushed
the
fibercallbacklistnoarray
branch
from
4596397 to
0e48903
Compare
|
@sebmarkbage Ok I put the list on the UpdateQueue. |
|
I think my original feedback was too eager. I was thinking that we could reuse other parts of the linked list data structure for updates. I also added more uses of dynamic arrays in #8607. So maybe we can just leave it as is? |
|
Leave it as an array? Sure |
See #8728 (comment)