[Fiber] Throw when attempting to unmount at an invalid node #8688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweary
force-pushed
the
fiber-warn-invalid-node-unmount
branch
from
53133e1 to
deaf3e5
Compare
bvaughn
reviewed
Jan 4, 2017
| invariant( | ||
| isValidContainer(container), | ||
| 'unmountComponentAtNode(...): Target container is not a DOM element.' | ||
| );t |
There was a problem hiding this comment.
Extra t on the end ^
Isn't this unnecessary though?
unmountComponentAtNode calls renderSubtreeIntoContainer which calls validateContainer which throws- just with a slightly different error message (eg "Target container is not a DOM element.")
There was a problem hiding this comment.
Maybe a better fix would just be to update the ReactMount-test to expect the slightly different error message based on ReactDOMFeatureFlags.useFiber?
There was a problem hiding this comment.
@bvaughn but renderSubtreeIntoContainer is only called if container._reactRootContainer exists, so it wouldn't actually throw, it would just be a no-op.
ConPho
approved these changes
Jan 5, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this failing test, figured it would be an easy fix 😄