Don't warn about class components using getInitialState if state is set #8594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… also set We warn about getInitialState() usage in class components because users may have accidentally used it instead of state. If they have also specified state though then we should skip this warning. Context: https://twitter.com/soprano/status/810003963286163456
sophiebits
approved these changes
Dec 17, 2016
bvaughn
deleted the
dont-warn-about-getInitialState-on-class-if-state-set
branch
|
@bvaughn Please attach |
|
Thanks @gaearon! I hadn't known about the labels. |
gaearon
pushed a commit
that referenced
this pull request
Jan 6, 2017
…-on-class-if-state-set Don't warn about class components using getInitialState if state is set (cherry picked from commit 3c6d4ba)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We warn about
getInitialState()usage in class components in case users accidentally used it when they should have used.state. If they have also specified.statethough then it seems unnecessary to blacklist this property name.Context: https://twitter.com/soprano/status/810003963286163456