Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New fiber-based ReactART renderer #8521

Merged
merged 1 commit into from
Dec 8, 2016
Merged

New fiber-based ReactART renderer #8521

merged 1 commit into from
Dec 8, 2016

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Dec 7, 2016 •
edited
Loading

Based on reactjs/react-art/pull/105, this PR:

  • Imports new fiber-based ReactART renderer. (Originally reviewed in www)
  • Split ReactART into ReactARTStack and ReactARTFiber (based on ReactDOMFeatureFlags)
  • Updates passing tests (7 previously failing tests now pass, 1 new passing test added).

Imported new ReactART fiber renderer
81cb216 
Split ReactART into stack and fiber targets. Added new ReactART test case for recently-fixed bug.
@sebmarkbage
Copy link
Collaborator

Looks like you have a lint error, otherwise we can land.

@bvaughn
Copy link
Contributor Author

bvaughn commented Dec 8, 2016 •
edited
Loading

Looking in CI, I see a lint error in src/renderers/shared/shared/__tests__/ReactCompositeComponentState-test.js but that file wasn't modified with this diff.

Looks like maybe that lint error was introduced in PR #8525 / commit 343fb95.

@bvaughn
Copy link
Contributor Author

bvaughn commented Dec 8, 2016

I'll fix the lint error with a follow-up PR (since it pre-dates this PR).

@bvaughn bvaughn merged commit 9510ecf into facebook:master Dec 8, 2016
@bvaughn bvaughn deleted the react-art-fiber branch December 8, 2016 02:35
@bvaughn bvaughn mentioned this pull request Dec 8, 2016
Merged
@sebmarkbage sebmarkbage mentioned this pull request Dec 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvaughn @sebmarkbage @facebook-github-bot