Preserve scroll position when restoring focus#8401
Merged
sophiebits merged 1 commit intofacebook:masterfrom Nov 23, 2016
Merged
Preserve scroll position when restoring focus#8401sophiebits merged 1 commit intofacebook:masterfrom
sophiebits merged 1 commit intofacebook:masterfrom
Conversation
This misbehavior is particularly egregious because of our current strategy for updating a container in Fiber, but regardless -- if we restore focus to an offscreen node (ex: because it was reordered among its siblings) then we should not scroll the page to reveal it. We could check the `overflow` computed style values before saving the scroll positions but that's unlikely to be any faster.
sebmarkbage
approved these changes
Nov 23, 2016
Contributor
sebmarkbage
left a comment
sebmarkbage
left a comment
There was a problem hiding this comment.
This might be overkill but nice to have.
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
This misbehavior is particularly egregious because of our current strategy for updating a container in Fiber, but regardless -- if we restore focus to an offscreen node (ex: because it was reordered among its siblings) then we should not scroll the page to reveal it. We could check the `overflow` computed style values before saving the scroll positions but that's unlikely to be any faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This misbehavior is particularly egregious because of our current strategy for updating a container in Fiber, but regardless -- if we restore focus to an offscreen node (ex: because it was reordered among its siblings) then we should not scroll the page to reveal it.
We could check the
overflowcomputed style values before saving the scroll positions but that's unlikely to be any faster.