[Fiber] Delete child when the key lines up but the type doesn't #8085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When keys line up in the beginning but the type doesn't we don't currently delete the child. We need to track that this fiber is a not a reuse and if so mark the old one for deletion.
sebmarkbage
commented
Oct 25, 2016
| @@ -573,7 +580,7 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) { | |||
| // it from the child list so that we don't add it to the deletion | |||
| // list. | |||
| existingChildren.delete( | |||
| newFiber.key === null ? newFiber.index : newFiber.key | |||
| newFiber.key === null ? newIdx : newFiber.key | |||
There was a problem hiding this comment.
newFiber.index will be 0 if this is a clone. The index we actually matched on is oldFiber.index which also happens to be the same as newIdx which is what we just looked up in the map.
|
Gonna trust you on this one and later figure out how child reconciliation works in more detail. |
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
When keys line up in the beginning but the type doesn't we don't currently delete the child. We need to track that this fiber is a not a reuse and if so mark the old one for deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When keys line up in the beginning but the type doesn't we don't currently delete the child. We need to track that this fiber is a not a reuse and if so mark the old one for deletion.