[Fiber] State Updates #7941
Merged
[Fiber] State Updates #7941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! 👍 |
|
Oh oops didn't see you still have steps to do. Commits so far look good. |
|
Well at this point maybe we need quicker turn around on PRs for collaboration. |
9 tasks
acdlite
reviewed
Oct 12, 2016
| @@ -291,7 +291,7 @@ module.exports = function<T, P, I, TI, C>(config : HostConfig<T, P, I, TI, C>) { | |||
| const prevProps = current.memoizedProps; | |||
| // TODO: This is the new state. We don't currently have the previous | |||
| // state anymore. | |||
sebmarkbage
force-pushed
the
fibersetstate
branch
from
d2fe722 to
de85aa5
Compare
|
Can we get it merged as is for now? It's hard to fix/test/explore Fiber with massive changes hanging in a PR. I don't think anybody expects it to be perfect. |
|
Agreed, the existing commits are useful even without the remaining steps. |
|
I'm going to mark this as accepted to indicate that the existing commits should be merged, but if you disagree @sebmarkbage feel free to remove it. |
This was referenced Oct 17, 2016
Refactors the class logic a bit. I moved scheduleUpdate out into the scheduler since that's where the scheduling normally happens. I also moved it so that we can rely on hoisting to resolve the cycle statically. I moved the updater to a new class component file. I suspect we will need a bit of space in here since the class initialization code is quite complex. The class component dependency is currently fixed in BeginWork so we can't move complete or commit phase stuff to it. If we need to, we have to initialize it in the scheduler and pass it to the other phases.
The root is always a host container.
We forgot to clone this value so it didn't work before. This is covered by existing tests in ReactDOMProduction.
sebmarkbage
force-pushed
the
fibersetstate
branch
from
de85aa5 to
c50502c
Compare
|
Cool I'll continue in a new PR. I have found another bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm putting some work into state updates since there is currently a bug that I haven't been able to track down. Builds on top #7707.