Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bail out of dedupe logic in cases where there is an incomplete value descriptor #6648

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Bail out of dedupe logic in cases where there is an incomplete value descriptor #6648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/renderers/dom/client/inputValueTracking.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,15 @@ var inputValueTracking = {

var currentValue = '' + node[valueField];

// if someone has already defined a value bail and don't track value
// will cause over reporting of changes, but it's better then a hard failure
// (needed for certain tests that spyOn input values)
if (node.hasOwnProperty(valueField)) {
// if someone has already defined a value or Safari, then bail
// and don't track value will cause over reporting of changes,
// but it's better then a hard failure
// (needed for certain tests that spyOn input values and Safari)
if (
node.hasOwnProperty(valueField) ||
typeof descriptor.get !== 'function' ||
typeof descriptor.set !== 'function'
) {
return;
}

Expand Down