Added additional detail to "props-in-getInitialState" anti-pattern doc #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
| @@ -11,7 +11,9 @@ next: dom-event-listeners.html | |||
| > | |||
| > This isn't really a React-specific tip, as such anti-patterns often occur in code in general; in this case, React simply points them out more clearly. | |||
|
|
|||
| Using props, passed down from parent, to generate state in `getInitialState` often leads to duplication of "source of truth", i.e. where the real data is. Whenever possible, compute values on-the-fly to ensure that they don't get out of sync later on and cause maintenance trouble. | |||
| Using props, passed down from parent, to generate state in `getInitialState` often leads to duplication of "source of truth", i.e. where the real data is. This is because `getInitialState` is only invoked when the component is first created. | |||
There was a problem hiding this comment.
While you're here, could you clean up the first sentence and just remove the "passed down from parent" bit.
zpao
added
Component: Documentation & Website
and removed
GH Review: review-needed
labels
While seemingly self-explanatory, this clarifies the reasons props usage in getInitialState might be considered an antipattern.
|
@david0178418 updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Looks great, thanks! |
zpao
added a commit
that referenced
this pull request
Jan 14, 2016
Added additional detail to "props-in-getInitialState" anti-pattern doc
zpao
added a commit
that referenced
this pull request
Jan 28, 2016
Added additional detail to "props-in-getInitialState" anti-pattern doc (cherry picked from commit f1c1544)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While seemingly self-explanatory, this clarifies the reasons props usage in getInitialState might be considered an antipattern.