[react-dom] Fire onReset when automatically resetting forms#35176
Merged
eps1lon merged 3 commits intofacebook:mainfrom Feb 2, 2026
Merged
[react-dom] Fire onReset when automatically resetting forms#35176eps1lon merged 3 commits intofacebook:mainfrom
eps1lon merged 3 commits intofacebook:mainfrom
Conversation
|
Comparing: b546603...4aa67d7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
16c78d7 to
4aa67d7
Compare
acdlite
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33630
During the mutation phase, we disabled the event emitter. This caused
onResetto be dropped when we automatically reset the form when a Form Action finishes. Controlled inputs would not have been reset if they're reset duringonReset.This could be implemented by scheduling the state updates from the Form Action instead. Arguably a footgun since you have to consider both now.
People could already work around by listening to the native
resetevent.