Skip to content

Conversation

@sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Sep 29, 2025

This brings the Suspense boundary that's switching into view so that when you play the loading sequence you can see how it plays out. Otherwise it's really hard to find where things are changing.

This assumes we'll also scroll synchronize the suspense tab which will bring it into view there too.

@sebmarkbage sebmarkbage requested a review from eps1lon September 29, 2025 23:48
@meta-cla meta-cla bot added the CLA Signed label Sep 29, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Sep 29, 2025
@sebmarkbage sebmarkbage merged commit 5dd163b into facebook:main Sep 30, 2025
241 checks passed
hoxyq added a commit that referenced this pull request Dec 10, 2025
…ed (#35294)

Follow-up to #34653.

React Native doesn't implement `getClientRect`, since this is applicable
to CSS box, which is not a concept for Native (maybe yet).

I am loosening the condition that gates `showOverlay()` call to pass if
`getClientRect` is not implemented.

Conceptually, everything that is inside `react-devtools-shared/backend`
should be Host-agnostic, because both on Web and Native it is installed
inside the Host JavaScript runtime, be it main frame of the page, or RN
instance. Since overlay & highlighting logic also lives there, it should
also follow these principles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants