Skip to content

[eprh] Temporarily disable compiler rules #34649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

[eprh] Temporarily disable compiler rules #34649

merged 1 commit into from
Sep 30, 2025
+0 −17

Conversation

@poteto
Copy link
Member

@poteto poteto commented Sep 29, 2025

Temporarily disables the compiler rules in eslint-plugin-react-hooks. Will revert this later.

@poteto
[eprh] Temporarily disable compiler rules
8b0bbcc 
Temporarily disables the compiler rules in eslint-plugin-react-hooks. Will revert this later.
@meta-cla meta-cla bot added the CLA Signed label Sep 29, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Sep 29, 2025
@react-sizebot
Copy link

Comparing: d15d7fd...8b0bbcc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 536.10 kB 536.10 kB = 94.79 kB 94.79 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.69 kB 663.69 kB = 117.00 kB 117.00 kB
facebook-www/ReactDOM-prod.classic.js = 687.59 kB 687.59 kB = 121.04 kB 121.04 kB
facebook-www/ReactDOM-prod.modern.js = 678.02 kB 678.02 kB = 119.39 kB 119.39 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,114.19 kB 177.00 kB = 303.28 kB 29.94 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,114.00 kB 176.82 kB = 303.26 kB 29.93 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,114.00 kB 176.82 kB = 303.26 kB 29.93 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,118.66 kB 176.95 kB = 304.29 kB 30.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,118.47 kB 176.76 kB = 304.27 kB 29.99 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,118.47 kB 176.76 kB = 304.27 kB 29.99 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,114.19 kB 177.00 kB = 303.28 kB 29.94 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,114.00 kB 176.82 kB = 303.26 kB 29.93 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,114.00 kB 176.82 kB = 303.26 kB 29.93 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,118.66 kB 176.95 kB = 304.29 kB 30.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,118.47 kB 176.76 kB = 304.27 kB 29.99 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,118.47 kB 176.76 kB = 304.27 kB 29.99 kB

Generated by 🚫 dangerJS against 8b0bbcc

@poteto poteto merged commit cf88408 into main Sep 30, 2025
247 checks passed
@poteto poteto deleted the pr34649 branch September 30, 2025 22:45
github-actions bot pushed a commit that referenced this pull request Sep 30, 2025
@poteto
[eprh] Temporarily disable compiler rules (#34649)
2cc1516 
Temporarily disables the compiler rules in eslint-plugin-react-hooks.
Will revert this later.

DiffTrain build for [cf88408](cf88408)
github-actions bot pushed a commit that referenced this pull request Sep 30, 2025
@poteto
[eprh] Temporarily disable compiler rules (#34649)
079fb4e 
Temporarily disables the compiler rules in eslint-plugin-react-hooks.
Will revert this later.

DiffTrain build for [cf88408](cf88408)
This was referenced Oct 1, 2025
Merged
Merged
poteto added a commit that referenced this pull request Oct 1, 2025
@poteto
[eprh] Allow compiler rules to be opted-in but not in the preset
17c19db 
Follow up to #34649. This adds the compiler rules back so they can be opted-in 6.1.0, but aren't included in the presets as that would be a breaking change.
@poteto poteto mentioned this pull request Oct 1, 2025
Merged
poteto added a commit that referenced this pull request Oct 1, 2025
@poteto
[eprh] Allow compiler rules to be opted-in but not in the preset (#34672
ae74234 
)

Follow up to #34649. This adds the compiler rules back so they can be
opted-in 6.1.0, but aren't included in the presets as that would be a
breaking change.
github-actions bot pushed a commit that referenced this pull request Oct 1, 2025
@poteto
[eprh] Allow compiler rules to be opted-in but not in the preset (#34672
108e31b 
)

Follow up to #34649. This adds the compiler rules back so they can be
opted-in 6.1.0, but aren't included in the presets as that would be a
breaking change.

DiffTrain build for [ae74234](ae74234)
github-actions bot pushed a commit that referenced this pull request Oct 1, 2025
@poteto
[eprh] Allow compiler rules to be opted-in but not in the preset (#34672
44686cc 
)

Follow up to #34649. This adds the compiler rules back so they can be
opted-in 6.1.0, but aren't included in the presets as that would be a
breaking change.

DiffTrain build for [ae74234](ae74234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephsavona josephsavona josephsavona approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@poteto @react-sizebot @josephsavona