[Fizz] Clean up the replay nodes if we're already rendered past an element #33581
Merged
eps1lon merged 2 commits intofacebook:mainfrom Jun 20, 2025
Merged
[Fizz] Clean up the replay nodes if we're already rendered past an element #33581eps1lon merged 2 commits intofacebook:mainfrom
eps1lon merged 2 commits intofacebook:mainfrom
Conversation
|
Comparing: a947eba...917c674 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
approved these changes
Jun 20, 2025
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #27513. There's two issues here.
First, we didn't restore the ReplaySet when calling
renderNode()so it was not safe to invoke since future siblings might observe the mutated replay. This could skip replays which covered up errors.Second, this was covering up that we weren't properly cleaning up the replay nodes when we were able to render through one node and then mutated the
.nodeon the task but then suspended deeper.I don't love the solution from #27513 in general because it feels hacky to compare the mutated node. It should probably be structured different. There's also another case that's basically the same case which has neither of these fixes in it. It's probably a bug too but haven't been able to repro yet:
react/packages/react-server/src/ReactFizzServer.js
Lines 3612 to 3613 in a947eba