Skip to content

[not for merge] Check if Flight fixture smoke tests use correct build #33425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jun 3, 2025

No description provided.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 3, 2025
@react-sizebot
Copy link

react-sizebot commented Jun 3, 2025

Comparing: 3fb17d1...7226884

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 529.82 kB 529.84 kB = 93.51 kB 93.52 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 650.91 kB 650.94 kB +0.01% 114.63 kB 114.65 kB
facebook-www/ReactDOM-prod.classic.js = 675.86 kB 675.89 kB +0.01% 118.91 kB 118.93 kB
facebook-www/ReactDOM-prod.modern.js = 666.14 kB 666.17 kB +0.01% 117.30 kB 117.32 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 170.83 kB 163.62 kB = 31.76 kB 30.40 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 170.76 kB 163.55 kB = 31.75 kB 30.38 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 169.63 kB 162.42 kB = 31.46 kB 30.10 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js = 162.96 kB 155.75 kB = 30.36 kB 29.05 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 162.93 kB 155.72 kB = 30.35 kB 29.05 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js = 2.34 kB 0.36 kB = 0.91 kB 0.25 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js = 2.34 kB 0.36 kB = 0.91 kB 0.25 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js = 2.34 kB 0.36 kB = 0.91 kB 0.25 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js +0.29% 88.29 kB 88.55 kB +0.40% 18.38 kB 18.45 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js +0.29% 88.29 kB 88.55 kB +0.40% 18.38 kB 18.45 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js +0.28% 92.98 kB 93.23 kB +0.36% 19.15 kB 19.22 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +0.27% 95.20 kB 95.46 kB +0.37% 19.50 kB 19.57 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +0.27% 95.20 kB 95.46 kB +0.37% 19.50 kB 19.57 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +0.27% 95.22 kB 95.48 kB +0.37% 19.49 kB 19.56 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +0.27% 95.22 kB 95.48 kB +0.37% 19.49 kB 19.56 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +0.26% 99.89 kB 100.15 kB +0.33% 20.37 kB 20.44 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +0.26% 99.91 kB 100.17 kB +0.33% 20.37 kB 20.43 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 136.38 kB 136.03 kB = 31.96 kB 31.85 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 136.36 kB 136.01 kB = 31.94 kB 31.83 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js = 575.52 kB 572.35 kB = 102.87 kB 102.34 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 164.77 kB 163.26 kB = 30.31 kB 30.12 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 164.74 kB 163.23 kB = 30.31 kB 30.12 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 121.63 kB 120.47 kB = 22.61 kB 22.45 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 156.99 kB 155.48 kB = 28.95 kB 28.78 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 120.30 kB 119.14 kB = 22.36 kB 22.19 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 119.39 kB 118.24 kB = 22.49 kB 22.32 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 119.30 kB 118.15 kB = 22.45 kB 22.28 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 117.56 kB 116.40 kB = 22.08 kB 21.92 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 116.21 kB 115.05 kB = 21.96 kB 21.78 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 114.92 kB 113.76 kB = 21.60 kB 21.44 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 157.36 kB 155.78 kB = 29.03 kB 28.83 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 157.36 kB 155.78 kB = 29.03 kB 28.83 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 157.34 kB 155.75 kB = 29.03 kB 28.83 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 157.34 kB 155.75 kB = 29.03 kB 28.83 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 114.41 kB 113.25 kB = 21.58 kB 21.41 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 113.06 kB 111.91 kB = 21.37 kB 21.19 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 112.51 kB 111.35 kB = 21.23 kB 21.04 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 111.97 kB 110.81 kB = 20.60 kB 20.42 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 110.68 kB 109.52 kB = 20.78 kB 20.60 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 110.32 kB 109.16 kB = 20.84 kB 20.65 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 149.59 kB 148.00 kB = 27.69 kB 27.48 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 149.59 kB 148.00 kB = 27.69 kB 27.48 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 149.42 kB 147.74 kB = 35.01 kB 34.70 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 158.28 kB 156.48 kB = 29.39 kB 29.11 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 158.28 kB 156.48 kB = 29.39 kB 29.11 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 158.22 kB 156.41 kB = 29.38 kB 29.10 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 158.22 kB 156.41 kB = 29.38 kB 29.10 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 157.08 kB 155.28 kB = 29.11 kB 28.82 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 157.08 kB 155.28 kB = 29.11 kB 28.82 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 154.30 kB 152.47 kB = 28.64 kB 28.34 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 154.30 kB 152.47 kB = 28.64 kB 28.34 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 153.76 kB 151.92 kB = 28.50 kB 28.20 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 153.76 kB 151.92 kB = 28.50 kB 28.20 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js = 150.41 kB 148.61 kB = 27.99 kB 27.70 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js = 150.41 kB 148.61 kB = 27.99 kB 27.70 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 150.39 kB 148.58 kB = 28.01 kB 27.73 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 150.39 kB 148.58 kB = 28.01 kB 27.73 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 146.02 kB 144.18 kB = 27.17 kB 26.88 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 146.02 kB 144.18 kB = 27.17 kB 26.88 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 161.35 kB 159.31 kB = 29.90 kB 29.58 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 160.81 kB 158.77 kB = 29.77 kB 29.46 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 153.07 kB 151.03 kB = 28.40 kB 28.08 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js = 107.13 kB 105.30 kB = 19.95 kB 19.64 kB
oss-stable/react-server/cjs/react-server-flight.development.js = 107.13 kB 105.30 kB = 19.95 kB 19.64 kB
oss-experimental/react-server/cjs/react-server-flight.development.js = 114.17 kB 112.13 kB = 21.18 kB 20.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 170.83 kB 163.62 kB = 31.76 kB 30.40 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 170.76 kB 163.55 kB = 31.75 kB 30.38 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 169.63 kB 162.42 kB = 31.46 kB 30.10 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js = 162.96 kB 155.75 kB = 30.36 kB 29.05 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 162.93 kB 155.72 kB = 30.35 kB 29.05 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js = 2.34 kB 0.36 kB = 0.91 kB 0.25 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js = 2.34 kB 0.36 kB = 0.91 kB 0.25 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js = 2.34 kB 0.36 kB = 0.91 kB 0.25 kB

Generated by 🚫 dangerJS against 7226884

@eps1lon eps1lon force-pushed the sebbie/flight-fixture-smoke branch from 6c077e0 to 7226884 Compare June 3, 2025 18:45
@eps1lon
Copy link
Collaborator Author

eps1lon commented Jun 3, 2025

Still captures bugs. The reason it didn't flag #33392 originally was a timing issue because CI is slower. I could get it to work locally when stepping through the code but it failed when I let it run as fast as possible.

@eps1lon eps1lon closed this Jun 3, 2025
@eps1lon eps1lon deleted the sebbie/flight-fixture-smoke branch June 3, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants