[Flight] Log "Server Requests" Track #33394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
force-pushed
the
ioperformancetrack
branch
2 times, most recently
from
12621f5 to
0ca49ea
Compare
eps1lon
approved these changes
Jun 3, 2025
Helps distinguish various helpers like fetch vs query. I also switched dedupes to use primary/secondary color. It was standing out too much. By using the tertiary color for I/O we can avoid confusing the color with the color Server Components. This lets us associate the I/O track with the await in the Server Components track by using the same color scheme but make it different from Server Component rendering.
sebmarkbage
force-pushed
the
ioperformancetrack
branch
from
0ca49ea to
8ce8c1a
Compare
sebmarkbage
added a commit
that referenced
this pull request
Jun 3, 2025
Stacked on #33394. This lets us create async stack traces to the owner that was in context when the I/O was started or awaited. <img width="615" alt="Screenshot 2025-06-01 at 12 31 52 AM" src="https://github.com/user-attachments/assets/6ff5a146-33d6-4a4b-84af-1b57e73047d4" /> This owner might not be the immediate closest parent where the I/O was awaited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #33392.
This adds another track to the Performance Track called
"Server Requests".This logs the flat list of I/O awaited on by Server Components. There will be other views that are more focused on what data blocks a specific Component or Suspense boundary but this is just the list of all the I/O basically so you can get an overview of those waterfalls without the noise of all the Component trees and rendering. It's similar to what the "Network" track is on the client.
I've been going back and forth on what to call this track but I went with
"Server Requests"for now. The idea is that the name should communicate that this is something that happens on the server and is a pairing with the"Server Components"track. Although we don't use that feature, since it's missing granularity, it's also similar to "Server Timings".