Skip to content

enableViewTransition in www #33357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

enableViewTransition in www #33357

merged 1 commit into from
May 27, 2025

Conversation

kassens
Copy link
Member

@kassens kassens commented May 27, 2025 •
edited
Loading

No description provided.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 27, 2025
@react-sizebot
Copy link

Comparing: c0464ae...f71050d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 529.83 kB 529.83 kB = 93.51 kB 93.52 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 650.93 kB 650.93 kB = 114.65 kB 114.65 kB
facebook-www/ReactDOM-prod.classic.js = 675.87 kB 674.07 kB = 118.93 kB 118.56 kB
facebook-www/ReactDOM-prod.modern.js = 666.15 kB 664.42 kB = 117.31 kB 116.94 kB
facebook-www/ReactTestRenderer-dev.modern.js +5.43% 588.75 kB 620.74 kB +5.57% 95.09 kB 100.38 kB
facebook-www/ReactTestRenderer-dev.classic.js +5.43% 588.75 kB 620.74 kB +5.57% 95.09 kB 100.38 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactTestRenderer-dev.modern.js +5.43% 588.75 kB 620.74 kB +5.57% 95.09 kB 100.38 kB
facebook-www/ReactTestRenderer-dev.classic.js +5.43% 588.75 kB 620.74 kB +5.57% 95.09 kB 100.38 kB
facebook-www/ReactDOM-profiling.classic.js = 746.13 kB 744.38 kB = 128.28 kB 127.95 kB
facebook-www/ReactDOM-profiling.modern.js = 738.09 kB 736.33 kB = 126.99 kB 126.64 kB
facebook-www/ReactDOMTesting-prod.modern.js = 680.55 kB 678.82 kB = 120.95 kB 120.58 kB
facebook-www/ReactDOM-prod.modern.js = 666.15 kB 664.42 kB = 117.31 kB 116.94 kB
facebook-www/ReactDOMTesting-prod.classic.js = 690.27 kB 688.48 kB = 122.51 kB 122.16 kB
facebook-www/ReactReconciler-dev.classic.js = 847.51 kB 845.29 kB = 131.58 kB 131.25 kB
facebook-www/ReactReconciler-dev.modern.js = 838.31 kB 836.09 kB = 129.81 kB 129.47 kB
facebook-www/ReactDOM-prod.classic.js = 675.87 kB 674.07 kB = 118.93 kB 118.56 kB
facebook-www/ReactART-dev.classic.js = 731.51 kB 729.36 kB = 113.86 kB 113.54 kB
facebook-www/ReactART-dev.modern.js = 722.02 kB 719.87 kB = 112.11 kB 111.78 kB
facebook-www/React-dev.classic.js = 56.15 kB 55.96 kB = 12.31 kB 12.30 kB
facebook-www/React-dev.modern.js = 56.14 kB 55.96 kB = 12.30 kB 12.29 kB
facebook-www/ReactReconciler-prod.modern.js = 499.98 kB 498.08 kB = 79.80 kB 79.49 kB
facebook-www/ReactReconciler-prod.classic.js = 510.28 kB 508.32 kB = 81.39 kB 81.06 kB
facebook-www/ReactART-prod.modern.js = 377.77 kB 375.98 kB = 63.28 kB 62.99 kB
facebook-www/ReactART-prod.classic.js = 387.76 kB 385.90 kB = 64.92 kB 64.61 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 13.37 kB 13.28 kB = 3.60 kB 3.59 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 13.37 kB 13.28 kB = 3.60 kB 3.59 kB
facebook-www/React-profiling.classic.js = 21.45 kB 21.30 kB = 5.44 kB 5.43 kB
facebook-www/React-profiling.modern.js = 21.45 kB 21.30 kB = 5.44 kB 5.42 kB
facebook-www/React-prod.classic.js = 21.01 kB 20.87 kB = 5.36 kB 5.34 kB
facebook-www/React-prod.modern.js = 21.01 kB 20.87 kB = 5.36 kB 5.34 kB
facebook-www/ReactIs-dev.classic.js = 6.49 kB 6.40 kB = 1.40 kB 1.39 kB
facebook-www/ReactIs-dev.modern.js = 6.49 kB 6.40 kB = 1.40 kB 1.39 kB
facebook-www/ReactIs-prod.classic.js = 5.89 kB 5.80 kB = 1.37 kB 1.36 kB
facebook-www/ReactIs-prod.modern.js = 5.89 kB 5.80 kB = 1.37 kB 1.36 kB

Generated by 🚫 dangerJS against f71050d

rickhanlonii
rickhanlonii approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kassens kassens merged commit f702620 into facebook:main May 27, 2025
246 checks passed
@kassens kassens deleted the pr33357 branch May 27, 2025 15:23
github-actions bot pushed a commit that referenced this pull request May 27, 2025
@kassens
[fb-www] ship enableViewTransition (#33357)
4dbb17c 
DiffTrain build for [f702620](f702620)
@vercel-release-bot vercel-release-bot mentioned this pull request May 27, 2025
Closed
@rickhanlonii rickhanlonii changed the title [fb-www] ship enableViewTransition enableViewTransition in www May 27, 2025
kassens added a commit that referenced this pull request May 27, 2025
@kassens
Revert "[fb-www] ship enableViewTransition (#33357)"
21b5593 
This reverts commit f702620.
@kassens kassens mentioned this pull request May 27, 2025
Merged
kassens added a commit that referenced this pull request May 27, 2025
@kassens
Revert "enableViewTransition in www" (#33362)
283f87f 
We need to do some more testing here.

Reverts #33357
github-actions bot pushed a commit that referenced this pull request May 27, 2025
@kassens
Revert "enableViewTransition in www" (#33362)
7f8efe8 
We need to do some more testing here.

Reverts #33357

DiffTrain build for [283f87f](283f87f)
github-actions bot pushed a commit to code/lib-react that referenced this pull request May 28, 2025
@pull
Revert "enableViewTransition in www" (facebook#33362)
1dc9383 
We need to do some more testing here.

Reverts facebook#33357

DiffTrain build for [283f87f](facebook@283f87f)
@vercel-release-bot vercel-release-bot mentioned this pull request May 28, 2025
Merged
@eps1lon eps1lon mentioned this pull request Jun 7, 2025
Draft
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @react-sizebot @rickhanlonii @facebook-github-bot