Skip to content

[Fizz] Apply View Transition Name and Class to SSR:ed View Transitions #33332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025

Conversation

sebmarkbage
Copy link
Collaborator

Stacked on #33330.

This walks the element tree to activate the various classes under different scenarios. There are some edge case things that are a little different since we can't express every scenario without virtual nodes.

The main thing that's still missing though is avoiding animating updates if it can be contained to a layout or enter/exit/share if they're out of the viewport. I.e. layout stuff.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 22, 2025
@react-sizebot
Copy link

react-sizebot commented May 22, 2025

Comparing: 91ac1fe...6bfd776

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.16% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 529.83 kB 529.83 kB = 93.51 kB 93.52 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.22% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.62 kB 651.62 kB = 114.80 kB 114.80 kB
facebook-www/ReactDOM-prod.classic.js = 675.87 kB 675.87 kB = 118.92 kB 118.93 kB
facebook-www/ReactDOM-prod.modern.js = 666.15 kB 666.15 kB = 117.31 kB 117.31 kB
oss-experimental/react-dom/unstable_server-external-runtime.js +51.65% 10.28 kB 15.59 kB +34.39% 2.72 kB 3.65 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/unstable_server-external-runtime.js +51.65% 10.28 kB 15.59 kB +34.39% 2.72 kB 3.65 kB
oss-experimental/react-markup/cjs/react-markup.production.js +1.22% 242.85 kB 245.81 kB +1.44% 44.20 kB 44.83 kB
facebook-www/ReactDOMServer-prod.modern.js +1.22% 243.22 kB 246.18 kB +1.52% 43.47 kB 44.13 kB
facebook-www/ReactDOMServer-prod.classic.js +1.19% 248.67 kB 251.62 kB +1.50% 44.21 kB 44.88 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +1.16% 254.49 kB 257.45 kB +1.47% 46.21 kB 46.88 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.js +1.15% 256.22 kB 259.18 kB +1.43% 45.26 kB 45.90 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.js +1.13% 261.29 kB 264.24 kB +1.43% 47.15 kB 47.82 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js +1.11% 266.56 kB 269.52 kB +1.40% 47.37 kB 48.03 kB
oss-experimental/react-markup/cjs/react-markup.react-server.production.js +0.86% 343.89 kB 346.85 kB +0.98% 63.51 kB 64.13 kB
oss-experimental/react-markup/cjs/react-markup.development.js +0.77% 385.22 kB 388.18 kB +0.99% 68.95 kB 69.63 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +0.74% 398.83 kB 401.78 kB +0.85% 71.21 kB 71.82 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.production.js +0.59% 250.66 kB 252.13 kB +1.46% 44.88 kB 45.53 kB
oss-stable/react-dom/cjs/react-dom-server.browser.production.js +0.59% 250.73 kB 252.21 kB +1.46% 44.90 kB 45.56 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.js +0.59% 252.56 kB 254.04 kB +1.43% 45.88 kB 46.54 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.js +0.59% 252.64 kB 254.11 kB +1.43% 45.91 kB 46.56 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.production.js +0.58% 255.97 kB 257.45 kB +1.43% 46.84 kB 47.51 kB
oss-stable/react-dom/cjs/react-dom-server.edge.production.js +0.58% 256.04 kB 257.52 kB +1.44% 46.86 kB 47.54 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js +0.52% 567.02 kB 569.98 kB +0.71% 101.12 kB 101.84 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js +0.51% 287.31 kB 288.79 kB +1.22% 49.66 kB 50.26 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.js +0.51% 289.21 kB 290.69 kB +1.20% 50.86 kB 51.47 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js +0.50% 293.24 kB 294.72 kB +1.15% 51.85 kB 52.44 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js +0.39% 375.46 kB 376.94 kB +0.87% 71.28 kB 71.90 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js +0.37% 399.17 kB 400.65 kB +0.81% 71.54 kB 72.12 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js +0.37% 399.25 kB 400.72 kB +0.82% 71.59 kB 72.17 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js +0.37% 402.61 kB 404.09 kB +0.81% 72.18 kB 72.76 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js +0.37% 402.68 kB 404.16 kB +0.81% 72.23 kB 72.81 kB
facebook-www/ReactDOMServer-dev.modern.js +0.37% 403.03 kB 404.51 kB +0.82% 71.92 kB 72.51 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js +0.37% 403.39 kB 404.87 kB +0.80% 72.33 kB 72.91 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js +0.37% 403.46 kB 404.94 kB +0.81% 72.37 kB 72.96 kB
facebook-www/ReactDOMServer-dev.classic.js +0.36% 406.49 kB 407.97 kB +0.82% 72.48 kB 73.07 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js +0.36% 415.66 kB 417.14 kB +0.81% 73.45 kB 74.04 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.36% 415.66 kB 417.14 kB +0.81% 73.44 kB 74.04 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +0.33% 441.70 kB 443.18 kB +0.78% 76.77 kB 77.37 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js +0.33% 445.71 kB 447.19 kB +0.77% 77.41 kB 78.01 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js +0.33% 446.71 kB 448.19 kB +0.77% 77.62 kB 78.22 kB

Generated by 🚫 dangerJS against 6bfd776

This is auto-detected now from the HTML.
@sebmarkbage sebmarkbage merged commit 8ce15b0 into facebook:main May 22, 2025
240 checks passed
github-actions bot pushed a commit that referenced this pull request May 22, 2025
#33332)

Stacked on #33330.

This walks the element tree to activate the various classes under
different scenarios. There are some edge case things that are a little
different since we can't express every scenario without virtual nodes.

The main thing that's still missing though is avoiding animating updates
if it can be contained to a layout or enter/exit/share if they're out of
the viewport. I.e. layout stuff.

DiffTrain build for [8ce15b0](8ce15b0)
github-actions bot pushed a commit to code/lib-react that referenced this pull request May 22, 2025
facebook#33332)

Stacked on facebook#33330.

This walks the element tree to activate the various classes under
different scenarios. There are some edge case things that are a little
different since we can't express every scenario without virtual nodes.

The main thing that's still missing though is avoiding animating updates
if it can be contained to a layout or enter/exit/share if they're out of
the viewport. I.e. layout stuff.

DiffTrain build for [8ce15b0](facebook@8ce15b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants