[Fizz] Clean up row that was blocked by an aborted boundary #33318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 50389e1...88098cc Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
commented
May 20, 2025
| @@ -4636,7 +4629,6 @@ function abortTask(task: Task, request: Request, error: mixed): void { | |||
| } | |||
| } | |||
| } else { | |||
| boundary.pendingTasks--; | |||
There was a problem hiding this comment.
Since some of the paths below here are going to take the finishedTask path and that does all the decrementing we need, we don't need to release anything above it. This is causing an extra task to be released (ending up in negative probably).
gnoff
approved these changes
May 20, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 21, 2025
…#33318) Fixes a bug that we caused us to hang after an abort because we didn't manage the ref count correctly. DiffTrain build for [9c7b10e](facebook@9c7b10e)
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that we caused us to hang after an abort because we didn't manage the ref count correctly.