Skip to content

Don't consider Portals animating unless they're wrapped in a ViewTransition #33191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

sebmarkbage
Copy link
Collaborator

And that doesn't disable with update="none".

The principle here is that we want the content of a Portal to animate if other things are animating with it but if other things aren't animating then we don't.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 13, 2025
@react-sizebot
Copy link

react-sizebot commented May 13, 2025

Comparing: 3a5b326...88362e6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 529.74 kB 529.74 kB = 93.49 kB 93.49 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.70 kB 651.42 kB +0.03% 114.70 kB 114.74 kB
facebook-www/ReactDOM-prod.classic.js = 675.93 kB 675.67 kB +0.02% 118.81 kB 118.83 kB
facebook-www/ReactDOM-prod.modern.js = 666.21 kB 665.95 kB +0.02% 117.18 kB 117.20 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 88362e6

…sition

And that doesn't disable with update="none"
Copy link
Member

@jackpope jackpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced this and it tested well internally. New semantics make more sense too. Thanks!

@sebmarkbage sebmarkbage merged commit 63d664b into facebook:main May 14, 2025
240 checks passed
github-actions bot pushed a commit that referenced this pull request May 14, 2025
…sition (#33191)

And that doesn't disable with `update="none"`.

The principle here is that we want the content of a Portal to animate if
other things are animating with it but if other things aren't animating
then we don't.

DiffTrain build for [63d664b](63d664b)
github-actions bot pushed a commit that referenced this pull request May 14, 2025
…sition (#33191)

And that doesn't disable with `update="none"`.

The principle here is that we want the content of a Portal to animate if
other things are animating with it but if other things aren't animating
then we don't.

DiffTrain build for [63d664b](63d664b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants