Add plumbing for onDefaultTransitionIndicator #33150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
May 7, 2025
| @@ -75,6 +84,11 @@ class Surface extends React.Component { | |||
| false, | |||
| false, | |||
| '', | |||
| defaultOnUncaughtError, | |||
| defaultOnCaughtError, | |||
| defaultOnRecoverableError, | |||
There was a problem hiding this comment.
These were missing in ART so any errors would've logged like onUncaughtError is undefined instead of the error. Probably not heavily used.
Probably should have a test for errors in ART.
sebmarkbage
force-pushed
the
transitionindicator
branch
from
f4a257a to
022a4b9
Compare
sebmarkbage
commented
May 8, 2025
| @@ -80,6 +80,7 @@ type CreateRootOptions = { | |||
| unstable_transitionCallbacks?: TransitionTracingCallbacks, | |||
| onUncaughtError?: (error: mixed, errorInfo: {componentStack: string}) => void, | |||
| onCaughtError?: (error: mixed, errorInfo: {componentStack: string}) => void, | |||
| onDefaultTransitionIndicator?: () => () => void, | |||
There was a problem hiding this comment.
Should the destroy be optional?
Typically you probably need it but if you use optimistic state then you don’t.
There was a problem hiding this comment.
Made it optional
sebmarkbage
force-pushed
the
transitionindicator
branch
from
d70d7ac to
9bf83c2
Compare
jackpope
approved these changes
May 8, 2025
sebmarkbage
added a commit
that referenced
this pull request
May 9, 2025
Stacked on #33150. We use `noop` functions in a lot of places as place holders. I don't think there's any real optimizations we get from having separate instances. This moves them to use a common instance in `shared/noop`.
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 9, 2025
Stacked on facebook#33150. We use `noop` functions in a lot of places as place holders. I don't think there's any real optimizations we get from having separate instances. This moves them to use a common instance in `shared/noop`. DiffTrain build for [21fdf30](facebook@21fdf30)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 9, 2025
Stacked on facebook#33150. We use `noop` functions in a lot of places as place holders. I don't think there's any real optimizations we get from having separate instances. This moves them to use a common instance in `shared/noop`. DiffTrain build for [21fdf30](facebook@21fdf30)
This was referenced May 9, 2025
This was referenced May 16, 2025
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds the options at the root and wire it up to the root but it doesn't do anything yet.