[compiler][playground][tests] Standardize more pragmas #33146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2025
mofeiZ
commented
May 8, 2025
| @@ -98,15 +98,15 @@ export type PluginOptions = { | |||
| * provided rules will skip compilation. To disable this feature (never bailout of compilation | |||
| * even if the default ESLint is suppressed), pass an empty array. | |||
| */ | |||
| eslintSuppressionRules?: Array<string> | null | undefined; | |||
| eslintSuppressionRules: Array<string> | null | undefined; | |||
There was a problem hiding this comment.
We're already spreading defaultOptions when parsing PluginOptions, which would set eslintSuppressionRules and sources if they were undefined in the Partial<PluginOptions> parameter. This type change should be a no-op
mofeiZ
commented
May 8, 2025
| function tryParseTestPragmaValue(val: string): Result<unknown, unknown> { | ||
| try { | ||
| let parsedVal: unknown; | ||
| const stringMatch = /^"([^"]*)"$/.exec(val); |
There was a problem hiding this comment.
This was needed for hookPattern strings which contain escape character sequences
mofeiZ
added a commit
that referenced
this pull request
May 8, 2025
see test fixtures --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33144). * #33146 * #33145 * __->__ #33144
mofeiZ
added a commit
that referenced
this pull request
May 8, 2025
`Environment.ts` is getting complex so let's separate test / playground parsing logic from it --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33145). * #33146 * __->__ #33145
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2025
see test fixtures --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33144). * #33146 * #33145 * __->__ #33144 DiffTrain build for [fbe7bc2](fbe7bc2)
(Almost) all pragmas are now one of the following: - `@...TestOnly`: custom pragma for test fixtures - `@<configName>` | `@<configName>:true`: enables with either true or a default enabled value - `@<configName>:<json value>`
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2025
`Environment.ts` is getting complex so let's separate test / playground parsing logic from it --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33145). * #33146 * __->__ #33145 DiffTrain build for [b629a86](b629a86)
This was referenced May 8, 2025
This was referenced May 15, 2025
This was referenced May 21, 2025
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Almost) all pragmas are now one of the following:
@...TestOnly: custom pragma for test fixtures@<configName>|@<configName>:true: enables with either true or a default enabled value@<configName>:<json value>