feat(compiler): implement constant folding for unary minus #33140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikeee
commented
May 7, 2025
| ) { | ||
| const result: Primitive = { | ||
| kind: 'Primitive', | ||
| value: operand.value * -1, |
There was a problem hiding this comment.
We're only operating on numbers here. Part in the spec:
https://tc39.es/ecma262/2024/#sec-unary-minus-operator-runtime-semantics-evaluation
josephsavona
approved these changes
May 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2025
## Summary `-constant` is represented as a `UnaryExpression` node that is currently not part of constant folding. If the operand is a constant number, the node is folded to `constant * -1`. This also coerces `-0` to `0`, resulting in `0 === -0` being folded to `true`. ## How did you test this change? See attached tests DiffTrain build for [946da51](946da51)
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2025
## Summary `-constant` is represented as a `UnaryExpression` node that is currently not part of constant folding. If the operand is a constant number, the node is folded to `constant * -1`. This also coerces `-0` to `0`, resulting in `0 === -0` being folded to `true`. ## How did you test this change? See attached tests DiffTrain build for [946da51](946da51)
This was referenced May 8, 2025
This was referenced May 15, 2025
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-constantis represented as aUnaryExpressionnode that is currently not part of constant folding. If the operand is a constant number, the node is folded toconstant * -1. This also coerces-0to0, resulting in0 === -0being folded totrue.How did you test this change?
See attached tests