[eslint-plugin-react-hooks] update fbsource build #33104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build output for fbsource by syncing the lint rules directly via including the eslint-plugin-react-hooks in the build artifacts.
- Updated the workflow to copy rather than move eslint-plugin-react-hooks for the standard build.
- Introduced a separate handling for fbsource that includes the full package (including package.json) for dependency management.
In order to sync the lint rules directly to internal, include the eslint plugin in the build output for fbsource.
poteto
approved these changes
May 2, 2025
|
Comparing: 4c4a57c...69ca0d2 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the fbsource build process to include the eslint-plugin-react-hooks in the build output, ensuring internal sync with lint rules.
- Replaces file moves with file copies for eslint-plugin-react-hooks.
- Adds a new step to copy the entire eslint-plugin-react-hooks package (including package.json) to the fbsource vendor folder.
jorge-cab
pushed a commit
that referenced
this pull request
May 2, 2025
In order to sync the lint rules directly to internal, include the eslint plugin in the build output for fbsource.
This was referenced May 5, 2025
rickhanlonii
added a commit
that referenced
this pull request
May 15, 2025
Noop detection for xplat syncs broke because `eslint-plugin-react-hooks` uses versions like: - `0.0.0-experimental-d85f86cf-20250514` But xplat expects them to be of the form: - `19.2.0-native-fb-63d664b2-20250514` This PR fixes the noop by ignoring `eslint-plugin-react-hooks/package.json` changes. This means we won't create a sync if only that package.json changes, but that should be rare and we can follow up with better detection if needed. [Example failed action](https://github.com/facebook/react/actions/runs/15032346805/job/42247414406): <img width="1031" alt="Screenshot 2025-05-15 at 11 31 17 AM" src="https://github.com/user-attachments/assets/d902079c-1afe-4e18-af1d-25e60e28929e" /> I believe the regression was caused by #33104
This was referenced May 15, 2025
This was referenced May 21, 2025
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to sync the lint rules directly to internal, include the eslint plugin in the build output for fbsource.