New children notify fragment instances in Fabric #33093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 4448b18...503b959 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
This is too early and causes the node to be observed before layout information is available. Going to to work on moving it later. |
jackpope
force-pushed
the
fr-rn-placements
branch
from
9d3ddac to
ce8e004
Compare
jackpope
force-pushed
the
fr-rn-placements
branch
from
ce8e004 to
cd6dbf0
Compare
|
Republishing as @rubennorte is working on RN changes to allow the earlier observe on new children. |
jbrown215
approved these changes
May 21, 2025
|
|
||
| if (!supportsMutation) { | ||
| if (enableFragmentRefs) { | ||
| appendImmutableNodeToFragmentInstances( |
There was a problem hiding this comment.
I'm not sure what supportsMutation means, but wanted to point out that we are appending something in the fragment refs path which might be considered a mutation?
There was a problem hiding this comment.
append isn't great naming here. I'll update.
supportsMutation refers to mutation mode https://github.com/facebook/react/blob/main/packages/react-reconciler/README.md#modes
In this case, we're targeting Fabric behavior which does not support mutation.
The append isn't an append to a mutable tree. Its more like letting the parent fragment know it has a new child, independent of the actual insert of that node.
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2025
When a new child of a fragment instance is inserted, we need to notify the instance to keep any relevant tracking up to date. For example, we automatically observe the new child with any active IntersectionObserver. For mutable renderers (DOM), we reuse the existing traversal in `commitPlacement` that does the insertions for HostComponents. Immutable renderers (Fabric) exit this path before the traversal though, so currently we can't notify the fragment instances. Here I've created a separate traversal in `commitPlacement`, specifically for immutable renders when `enableFragmentRefs` is on. DiffTrain build for [1835b3f](1835b3f)
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2025
When a new child of a fragment instance is inserted, we need to notify the instance to keep any relevant tracking up to date. For example, we automatically observe the new child with any active IntersectionObserver. For mutable renderers (DOM), we reuse the existing traversal in `commitPlacement` that does the insertions for HostComponents. Immutable renderers (Fabric) exit this path before the traversal though, so currently we can't notify the fragment instances. Here I've created a separate traversal in `commitPlacement`, specifically for immutable renders when `enableFragmentRefs` is on. DiffTrain build for [1835b3f](1835b3f)
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new child of a fragment instance is inserted, we need to notify the instance to keep any relevant tracking up to date. For example, we automatically observe the new child with any active IntersectionObserver.
For mutable renderers (DOM), we reuse the existing traversal in
commitPlacementthat does the insertions for HostComponents. Immutable renderers (Fabric) exit this path before the traversal though, so currently we can't notify the fragment instances.Here I've created a separate traversal in
commitPlacement, specifically for immutable renders whenenableFragmentRefsis on.