[mcp] Make tool more reliable and fix integration issues with babel #33074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorge-cab
changed the title
poteto
approved these changes
Apr 30, 2025
| @@ -356,7 +356,7 @@ Server Components - Shift data-heavy logic to the server whenever possible. Brea | |||
|
|
|||
| server.tool( | |||
| 'review-react-runtime', | |||
| 'Review the runtime of the code and get performance data to evaluate the proposed solution, the react code that is passed into this tool MUST contain an App component.', | |||
| 'Review the runtime of the code and get performance data to evaluate the proposed solution, the react code that is passed into this tool MUST contain an App functional component without arrow function. And DO NOT export anything', | |||
There was a problem hiding this comment.
Can you also add something like "run this tool every time you propose a performance related change to verify if your suggestion actually improves performance"
| @@ -48,10 +45,10 @@ export async function measurePerformance(code: any) { | |||
| * @param {Object} opts - Transformation options | |||
| * @returns {Promise<string>} - The transpiled code | |||
| */ | |||
| async function transformAsync(ast: babel.types.Node) { | |||
| async function transformAsync(ast: babel.types.Node, options: any) { | |||
There was a problem hiding this comment.
you can fix the any here by just removing this function and parseAsync. You can inline it directly into measurePerformance so everything is typed correctly.
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 1, 2025
…acebook#33074) ## Summary Fix babel presets, and add a bit more context to the tool so that it is more reliable ## How did you test this change? Manually tested the mcp integrated with claude desktop DiffTrain build for [d8074cb](facebook@d8074cb)
This was referenced May 1, 2025
This was referenced May 14, 2025
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix babel presets, and add a bit more context to the tool so that it is more reliable
How did you test this change?
Manually tested the mcp integrated with claude desktop