[devtools] Restore all Transitions for Tree updates #33042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Apr 28, 2025
Comment on lines
-98
to
-99
| inProgressRequests.delete(element); | ||
|
|
There was a problem hiding this comment.
If we delete it, subsequent reads will not read the resolved value and would instead need to manually re-render.
In our case, the read was happening after the ownersList event and therefore read nothing.
eps1lon
force-pushed
the
sebbie/rdt-restore-tree-transitions
branch
from
ffbdce3 to
b3aaf1e
Compare
hoxyq
approved these changes
Apr 29, 2025
eps1lon
force-pushed
the
sebbie/rdt-restore-tree-transitions
branch
from
b3aaf1e to
2430696
Compare
This was referenced May 1, 2025
hoxyq
pushed a commit
to hoxyq/react
that referenced
this pull request
May 7, 2025
hoxyq
added a commit
that referenced
this pull request
May 8, 2025
Patch release to mitigate #32659 Essentially just 6.1.1 with: * Restore all Transitions for Tree updates ([eps1lon](https://github.com/eps1lon) in [#33042](#33042)) * Restore "double-click to view owners tree" functionality ([eps1lon](https://github.com/eps1lon) in [#33039](#33039))
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2025
Patch release to mitigate #32659 Essentially just 6.1.1 with: * Restore all Transitions for Tree updates ([eps1lon](https://github.com/eps1lon) in [#33042](#33042)) * Restore "double-click to view owners tree" functionality ([eps1lon](https://github.com/eps1lon) in [#33039](#33039)) DiffTrain build for [557a647](557a647)
This was referenced May 8, 2025
This was referenced May 15, 2025
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #33039
Summary
Restores all the Transitions removed in #33039. We now kick of the fetch when we change the Owner instead of kicking it off in an Effect (you-might-not-need-an-effect).
How did you test this change?