Skip to content

Set accurate value for alwaysThrottleRetries on www #32684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

jackpope
Copy link
Member

@jackpope jackpope commented Mar 20, 2025

This flag value was updated in #28965 (seemingly unrelated, maybe as part of unit testing). But its still controlled by a dynamic flag in www. Let's update this to VARIANT to accurately represent the state of the rollout.

Before:
Screenshot 2025-03-20 at 10 45 30 AM

After:
Screenshot 2025-03-20 at 10 45 11 AM

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 20, 2025
@react-sizebot
Copy link

react-sizebot commented Mar 20, 2025

Comparing: a4f9bd5...5269946

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 517.29 kB = 92.26 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 617.58 kB 617.58 kB = 109.52 kB 109.52 kB
facebook-www/ReactDOM-prod.classic.js = 653.67 kB 653.67 kB = 115.18 kB 115.18 kB
facebook-www/ReactDOM-prod.modern.js = 643.95 kB 643.95 kB = 113.59 kB 113.59 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 5269946

@rickhanlonii
Copy link
Member

ahhhh that's why I thought it was rolled out already

@jackpope jackpope merged commit 7943da1 into facebook:main Mar 20, 2025
206 checks passed
@jackpope jackpope deleted the alwaysthrottleretries-fb branch March 20, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants