-
Notifications
You must be signed in to change notification settings - Fork 49.9k
Support non-dev builds in development environment #32341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…void entering act() logic - see also facebook/react#32341
…void entering act() logic - see also facebook/react#32341
…void entering act() logic - see also facebook/react#32341
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Please let anyone fix this or move this PR forward. |
|
Bump |
…void entering act() logic - see also facebook/react#32341 Based on: cul/ldpd-findingaids-asi@e6aa416
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
|
Please reopen, the issue is to my knowledge still not addressed and in mfe environment with e.g. Single spa you cannot run a single mfe locally in development mode while all other MFEs are running upstream in production mode. |
|
Agreed. This issue still remains as @wouter-leistra described. |
|
I managed to fix this issue for my case. Please see my comment here: #32030 (comment). Hope it helps others as well. |
|
Unfortunately we don't use module federation, just an import map with external declaration on the rspack config for react, react-dom, and other common shared packages. |
Summary
This PR is similar to the previous one, focusing on supporting elements or modules that were built for non-development environments.
ReactSharedInternals.actQueuecan be undefined instead of null, so the check has been modified to use a falsy check for better reliability.It fixes issues that can occur when using production-built third-party libraries or in microfrontend environments where multiple environments run together. If this PR is merged, it is expected to naturally resolve this issue as well.
The code has been modified following the approach used to resolve similar issues in the past.
ex1.
printWarningissue :
resolve:
ex2.
_store.validatedissue : #32061
resolve :
How did you test this change?
related: #32030