Skip to content

Conversation

@haesoo-y
Copy link

@haesoo-y haesoo-y commented Feb 8, 2025

Summary

This PR is similar to the previous one, focusing on supporting elements or modules that were built for non-development environments.

ReactSharedInternals.actQueue can be undefined instead of null, so the check has been modified to use a falsy check for better reliability.

It fixes issues that can occur when using production-built third-party libraries or in microfrontend environments where multiple environments run together. If this PR is merged, it is expected to naturally resolve this issue as well.

The code has been modified following the approach used to resolve similar issues in the past.

ex1. printWarning

issue :

resolve:

// consoleWithStackDev.rn.js
function printWarning(level, format, args) {
  if (enableRemoveConsolePatches) {
    return;
  }
  if (__DEV__) {
    if (ReactSharedInternals.getCurrentStack) { // << THIS CHECK

ex2. _store.validated

issue : #32061

resolve :

// ReactJSXElement.js
  if (__DEV__) {
    // The cloned element should inherit the original element's key validation.
    if (oldElement._store) {  // << THIS CHECK
      clonedElement._store.validated = oldElement._store.validated;
    }

How did you test this change?

yarn test

related: #32030

@github-actions
Copy link

github-actions bot commented Jun 6, 2025

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Jun 6, 2025
@wouter-leistra
Copy link

Please let anyone fix this or move this PR forward.

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Jun 7, 2025
@elyourn
Copy link

elyourn commented Jul 3, 2025

Bump

elohanlon added a commit to cul/ldpd-dcv that referenced this pull request Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Oct 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@github-actions github-actions bot closed this Oct 8, 2025
@wouter-leistra
Copy link

wouter-leistra commented Oct 8, 2025

Please reopen, the issue is to my knowledge still not addressed and in mfe environment with e.g. Single spa you cannot run a single mfe locally in development mode while all other MFEs are running upstream in production mode.

@vu-mai
Copy link

vu-mai commented Oct 9, 2025

Agreed. This issue still remains as @wouter-leistra described.

@vu-mai
Copy link

vu-mai commented Nov 17, 2025

I managed to fix this issue for my case. Please see my comment here: #32030 (comment). Hope it helps others as well.

@wouter-leistra
Copy link

Unfortunately we don't use module federation, just an import map with external declaration on the rspack config for react, react-dom, and other common shared packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Resolution: Stale Automatically closed due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: React 19 cannot run apps in both dev & production mode simultaneously

5 participants