tests[react-devtools]: added tests for Compiler integration #31241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 13411e4...16c30dc Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
hoxyq
force-pushed
the
react-devtools/compiler-integration-tests
branch
from
b26a2ea
to
b834e5c
Compare
hoxyq
force-pushed
the
react-devtools/compiler-integration-tests
branch
from
b834e5c
to
bcd54a0
Compare
poteto
approved these changes
Oct 16, 2024
| ) | ||
| ); | ||
| await exec( | ||
| `mv ${REGRESSION_FOLDER}/node_modules/react-compiler-runtime/dist/index.js ${buildPath}/react/compiler-runtime.js` |
There was a problem hiding this comment.
It seems confusing and maybe unnecessary to overrwrite react/compiler-runtime.js, but I see why it's useful to
There was a problem hiding this comment.
to overrwrite react/compiler-runtime.js
react/compiler-runtime.js is only shipped in React 19, and this check is gated for React [18.2, 19), so we don't override anything, just copying a script to replicate same react package structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for Compiler integration.
This includes:
For tests against React 18.2, I had to download
react-compiler-runtimefrom npm and put it toreact/compiler-runtime.js.