[compiler] Scaffold fixture library #31148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
What's the idea of the fixture library? |
|
@josephsavona to test out that the backwards compat stuff works in a real world setting. I can do it in a private repo somewhere if you prefer, just thought it'd be quicker and we have some precedent for react. It's also something I can link to later in the docs as an example guide. |
|
Ahhh right! No this makes sense! |
josephsavona
approved these changes
Oct 8, 2024
This was referenced Oct 10, 2024
Add missing directory to prettierignore.
Scaffolds an empty library to test backwards compatibility with the compiler enabled.
|
Comparing: de43d56...1f644c3 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
josephsavona
approved these changes
Oct 10, 2024
poteto
added a commit
that referenced
this pull request
Oct 10, 2024
Add missing directory to prettierignore. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31168). * #31167 * #31166 * #31165 * #31164 * #31148 * __->__ #31168
poteto
added a commit
that referenced
this pull request
Oct 10, 2024
Scaffold empty apps to consume the fixture lib. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31164). * #31167 * #31166 * #31165 * __->__ #31164 * #31148 * #31168
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaffolds an empty library to test backwards compatibility with the compiler enabled.
Stack created with Sapling. Best reviewed with ReviewStack.