Skip to content

[Flight] Track owner/stack where the Flight Client reads as the root #30933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2024
Merged

[Flight] Track owner/stack where the Flight Client reads as the root #30933

merged 1 commit into from
Sep 12, 2024

Conversation

sebmarkbage
Copy link
Collaborator

This means that the owner of a Component rendered on the remote server becomes the Component on this server.

Ideally we'd support this for the Client side too. In particular Fiber but currently ReactComponentInfo's owner is typed as only supporting other ReactComponentInfo and it's a bigger lift to support that.

@sebmarkbage sebmarkbage requested a review from gnoff September 10, 2024 16:48
@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 8:10pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 10, 2024
@react-sizebot
Copy link

react-sizebot commented Sep 10, 2024 •
edited
Loading

Comparing: 89b4457...39b07b5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 508.72 kB 508.72 kB = 90.98 kB 90.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 513.65 kB 513.65 kB = 91.70 kB 91.70 kB
facebook-www/ReactDOM-prod.classic.js = 602.81 kB 602.81 kB = 106.63 kB 106.63 kB
facebook-www/ReactDOM-prod.modern.js = 579.08 kB 579.08 kB = 102.76 kB 102.76 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +1.50% 126.14 kB 128.04 kB +1.75% 29.63 kB 30.15 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +1.26% 116.27 kB 117.73 kB +1.63% 27.30 kB 27.74 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +1.26% 116.27 kB 117.73 kB +1.63% 27.30 kB 27.74 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +1.26% 116.29 kB 117.75 kB +1.61% 27.32 kB 27.76 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.97% 89.51 kB 90.38 kB +0.92% 16.92 kB 17.07 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.95% 91.37 kB 92.24 kB +0.91% 17.31 kB 17.47 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.95% 91.82 kB 92.69 kB +0.89% 17.42 kB 17.58 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +0.94% 91.40 kB 92.26 kB +1.12% 16.81 kB 17.00 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.93% 93.71 kB 94.57 kB +0.86% 17.90 kB 18.06 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.90% 95.93 kB 96.80 kB +0.75% 18.39 kB 18.52 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.89% 97.30 kB 98.16 kB +0.79% 18.63 kB 18.78 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.89% 97.31 kB 98.18 kB +0.78% 18.61 kB 18.76 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.87% 99.05 kB 99.91 kB +0.72% 18.75 kB 18.88 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.86% 99.84 kB 100.70 kB +0.73% 18.92 kB 19.06 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.83% 81.94 kB 82.62 kB +0.77% 15.54 kB 15.66 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.83% 81.94 kB 82.62 kB +0.77% 15.54 kB 15.66 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.83% 81.98 kB 82.66 kB +0.76% 15.57 kB 15.68 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.81% 83.80 kB 84.48 kB +0.73% 15.95 kB 16.06 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.81% 83.80 kB 84.48 kB +0.73% 15.95 kB 16.06 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.81% 83.84 kB 84.52 kB +0.73% 15.97 kB 16.08 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.81% 84.25 kB 84.93 kB +0.71% 16.06 kB 16.17 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.81% 84.25 kB 84.93 kB +0.71% 16.06 kB 16.17 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.81% 84.29 kB 84.97 kB +0.74% 16.08 kB 16.20 kB
oss-stable-rc/react-client/cjs/react-client-flight.development.js +0.80% 84.25 kB 84.92 kB +0.81% 15.44 kB 15.56 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js +0.80% 84.25 kB 84.92 kB +0.81% 15.44 kB 15.56 kB
oss-stable/react-client/cjs/react-client-flight.development.js +0.80% 84.27 kB 84.94 kB +0.81% 15.46 kB 15.59 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.74% 86.08 kB 86.72 kB +0.73% 16.50 kB 16.62 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.74% 86.08 kB 86.72 kB +0.73% 16.50 kB 16.62 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.74% 86.08 kB 86.72 kB +0.73% 16.50 kB 16.62 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.72% 88.30 kB 88.94 kB +0.65% 16.98 kB 17.10 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.72% 88.30 kB 88.94 kB +0.65% 16.98 kB 17.10 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.72% 88.30 kB 88.94 kB +0.65% 16.98 kB 17.10 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.71% 89.67 kB 90.31 kB +0.65% 17.28 kB 17.39 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.71% 89.67 kB 90.31 kB +0.65% 17.28 kB 17.39 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.71% 89.67 kB 90.31 kB +0.65% 17.28 kB 17.39 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.71% 89.69 kB 90.32 kB +0.64% 17.26 kB 17.37 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.71% 89.69 kB 90.32 kB +0.64% 17.26 kB 17.37 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.71% 89.69 kB 90.32 kB +0.64% 17.26 kB 17.37 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.69% 91.43 kB 92.06 kB +0.66% 17.37 kB 17.48 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.69% 91.43 kB 92.06 kB +0.66% 17.37 kB 17.48 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.69% 91.43 kB 92.06 kB +0.66% 17.37 kB 17.48 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.68% 92.22 kB 92.85 kB +0.62% 17.54 kB 17.65 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.68% 92.22 kB 92.85 kB +0.62% 17.54 kB 17.65 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.68% 92.22 kB 92.85 kB +0.62% 17.54 kB 17.65 kB

Generated by 🚫 dangerJS against 05d7282

gnoff
gnoff approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@gnoff gnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is nice

@sebmarkbage
Track owner/stack where the Flight Client reads as the root
05d7282 
This means that the owner of a Component rendered on the remote server
becomes the Component on this server.

Ideally we'd support this for the Client side too. In particular Fiber
but currently ReactComponentInfo's owner is typed as only supporting other
ReactComponentInfo and it's a bigger lift to support that.
@sebmarkbage sebmarkbage merged commit dff5082 into facebook:main Sep 12, 2024
184 checks passed
@vercel-release-bot vercel-release-bot mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff gnoff approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @gnoff @facebook-github-bot