[Flight] do not emit error after abort #30683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 8e60bac...52e76a5 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
reviewed
Aug 14, 2024
| } | ||
|
|
||
| if (thrownValue === AbortSigil) { | ||
| if (request.status === ABORTING || x === AbortSymbol) { |
Collaborator
There was a problem hiding this comment.
No need to compare against the symbol since all cases it is thrown.
sebmarkbage
previously approved these changes
Aug 14, 2024
gnoff
force-pushed
the
handle-throws-after-abort
branch
from
0898d51 to
62fcdc8
Compare
gnoff
dismissed
sebmarkbage’s stale review
I updated the impl, needs another look
sebmarkbage
approved these changes
Aug 14, 2024
| (x: any).$$typeof === REACT_POSTPONE_TYPE | ||
| ) { | ||
| const postponeInstance: Postpone = (x: any); | ||
| logPostpone(request, postponeInstance.message, newTask); |
Collaborator
There was a problem hiding this comment.
Shouldn't postpone get the same treatment?
gnoff
force-pushed
the
handle-throws-after-abort
branch
from
62fcdc8 to
129c46f
Compare
gnoff
force-pushed
the
handle-throws-after-abort
branch
from
129c46f to
5772a5c
Compare
When synchronously aborting in a non-async Function Component if you throw after aborting the task would error rather than abort because React never observed the AbortSignal. This change adds an additional check to see if the request is currently aborting. I left the sigil check in place too in case a task pings after the request is closed (though I'm pretty sure that can't actually happen) I also renamed AbortSigil to AbortSymbol and changed it to a Symbol to make some of the duck typing more efficient.
gnoff
force-pushed
the
handle-throws-after-abort
branch
from
5772a5c to
e86eab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When synchronously aborting in a non-async Function Component if you throw after aborting the task would error rather than abort because React never observed the AbortSignal.
Using a sigil to throw after aborting during render isn't effective b/c the user code itself could throw so insteead we just read the request status. This is ok b/c we don't expect any tasks to still be pending after the currently running task finishes.
However I found one instance where that wasn't true related to serializing thenables which I've fixed so we may find other cases. If we do, though it's almost certainly a bug in our task bookkeeping so we should just fix it if it comes up.
I also updated
abortto not set the status to ABORTING unless the status was OPEN. we don't want to ever leave CLOSED or CLOSING status